Nov 2022

2 commits
Add test module for SLRUs
16 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #162 of 4 reviewers saw the final version

The commit retains all eleven files and the SQL tests from #16, with comment/layout polishing and replacement of the preload FATAL message by a structured ERROR in _PG_init(). The attachment retains Michael Paquier's author header from his rewrite in #15, and the commit credits both him and sender Aleksander Alekseev.

  • Pavel Borisovsaw the final versiontrailerPavel supported regression-test placement in #4, reviewed the expanded patch in #10, and explicitly endorsed the final submission in #18.
  • Daniel Gustafssonsaw the final versiontrailerDaniel questioned the original return-value API in #2 and reviewed the final submission in #17, suggesting pg_pwrite while otherwise finding nothing objectionable.
  • Noah Mischsaw an earlier versiontrailerNoah recommended regress.c placement in #3, before the later preload initialization and SQL-wrapper redesigns.
  • Maxim Orlovsaw an earlier versiontrailerMaxim recommended regression tests and limiting generalization in #6, prompting scope reductions before the substantial later redesigns.
Fix comment of SimpleLruInit() in slru.c
10 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.2REL_14_STABLE14.7
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #92 of 2 reviewers saw the final version

Extracts only the missing sync_handler documentation in src/backend/access/transam/slru.c from #9, rewording its reference to the enum as a direct description of sync-request handlers. Michael confirmed the separate commit and backpatch in #12.

  • Pavel Borisovsaw the final versionLLM analysis, 85% surePavel judged the containing patch ready to push in #10, before its sync_handler comment was extracted with only wording changes.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Aleksander Alekseev2
Michael Paquier1
Reviewer
Daniel Gustafsson1
Maxim Orlov1
Michael Paquiercommitter1
Noah Misch1
Pavel Borisov1
Committer
Michael Paquier2