Apr 2025

1 commit
Test restartpoints in archive recovery.
20 Apr 2025Noah Mischmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.5REL_16_STABLE16.9REL_15_STABLE15.13REL_14_STABLE14.18REL_13_STABLE13.21
LLM analysis, 100% surelanded as postedfrom patchset #462 of 2 reviewers saw the final version

The added test and meson registration exactly match #46; the commit message replaces its placeholders with the completed repair history.

  • Michael Paquiersaw the final versionLLM analysis, 100% sureQuestioned the test's detection rate and proposed injection points in #47 and #50, then withdrew his objection in #55.
  • Tom Lanesaw the final versionLLM analysis, 100% sureReviewed the runtime-versus-detection tradeoff in #48 and accepted proceeding without a better alternative in #54.

Apr 2025

7 commits
Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Assertion failure in WaitForWALToBecomeAvailable state machine (written from the discussion, no matching patch)
LLM analysis, 96% surelanded as postedfrom patchset #413 of 3 reviewers saw the final version

Exactly matches the final component of #41, removing the WalRcvStreaming() guard around XLogShutdownWalRcv(). Its attribution credits Bharath Rupireddy and Kyotaro Horiguchi for the implementation.

  • Dilip Kumarsaw the final versionLLM analysis, 100% sureExplicitly credited as a reviewer in 3635a0a35a, with no message in this thread.
  • Nathan Bossartsaw the final versionLLM analysis, 100% sureExplicitly credited as a reviewer of this fix in 3635a0a35a; its specific review is outside the supplied thread.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Skip WAL recycling and preallocation during archive recovery.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Race between KeepFileRestoredFromArchive() and restartpoint (part of a posted patchset)
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

Matches the sixth component of #41 in xlog.c, including the shared installation flag, archive-recovery checks and WAL-receiver shutdown wrapper.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Don't ERROR on PreallocXlogFiles() race condition.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Race between KeepFileRestoredFromArchive() and restartpoint (part of a posted patchset)
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

The changes to xlog.c, walreceiver.c and access/xlog.h exactly match the fifth component of #41, disregarding diff file ordering.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Revert "Add HINT for restartpoint race with KeepFileRestoredFromArchive()."
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21reverts 1 commit here
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

Exactly matches the fourth component of #41, removing the checkpointer-specific HINT from xlog.c and fd.c before the underlying race is fixed.

  • Noah Mischsaw the final versionLLM analysis, 98% sureConfirmed that Michael's backpatch series, including this independently authored revert, was correct in #46.
Remove XLogFileInit() ability to unlink a pre-existing file.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Race between KeepFileRestoredFromArchive() and restartpoint (part of a posted patchset)
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

The xlog.c, walreceiver.c and access/xlog.h changes match the third component of #41, with the header diff merely ordered differently.

  • Michael Paquiersaw the final versioncommittercommitted the patch
In XLogFileInit(), fix *use_existent postcondition to suit callers.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Race between KeepFileRestoredFromArchive() and restartpoint (part of a posted patchset)
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

Exactly matches the second component of #41 in xlog.c, correcting the segment-added accounting postcondition.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Remove XLogFileInit() ability to skip ControlFileLock.
6 Apr 2025Michael PaquierREL_14_STABLE14.18REL_13_STABLE13.21Also in: Race between KeepFileRestoredFromArchive() and restartpoint (part of a posted patchset)
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

Matches the first component of #41 across xlog.c, walreceiver.c and access/xlog.h, with no implementation edits beyond diff ordering.

  • Michael Paquiersaw the final versioncommittercommitted the patch

Jul 2022

2 commits
Remove durable_rename_excl()
5 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #261 of 3 reviewers saw the final version

All 71 deleted lines exactly match the helper-removal component of #26 across src/backend/storage/file/fd.c, src/include/pg_config_manual.h and src/include/storage/fd.h; differences are base context and commit-message wording.

  • Robert Haassaw an earlier versiontrailerAdvocated removing the unsafe helper in #2, before the original WAL-only patch expanded into caller conversion and API removal.
  • Kyotaro Horiguchisaw an earlier versiontrailerValidated ControlFileLock serialization and endorsed replacing the original WAL caller in #8, before the implementation expanded to remove the helper.
  • Michael Paquiersaw the final versiontrailerSupported helper removal in #14 and #19, reviewed the corrected series in #27, and committed the final removal.
Replace durable_rename_excl() by durable_rename(), take two
5 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19
LLM analysis, 100% surelanded as postedfrom patchset #261 of 3 reviewers saw the final version

Exactly matches the caller-conversion component of #26, including omission of the writeTimeLineHistoryFile() assertion; #28 confirms that component was applied.

  • Robert Haassaw an earlier versiontrailerProposed eliminating the unsafe helper in #2, before the patch expanded to all callers and subsequently changed its timeline-file checks.
  • Kyotaro Horiguchisaw an earlier versiontrailerAnalyzed ControlFileLock serialization and endorsed the original WAL fix in #8, before the broader caller conversion and timeline-race correction.
  • Michael Paquiersaw the final versiontrailerRequested assertions in #19, diagnosed their timeline race in #21, endorsed the corrected patch in #27 and committed it.

Apr 2022

2 commits
Remove durable_rename_excl()
28 Apr 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #201 of 3 reviewers saw the final version

Exactly matches the helper-removal component of #20, deleting durable_rename_excl(), its declaration and HAVE_WORKING_LINK. The identical component in #26 was posted after this commit.

  • Robert Haassaw an earlier versiontrailerAdvocated removing durable_rename_excl() in #2, before the concrete API-removal patch and its split for backpatching.
  • Kyotaro Horiguchisaw an earlier versiontrailerValidated the original WAL caller's replacement in #8, before the proposal expanded to eliminate the helper itself.
  • Michael Paquiersaw the final versiontrailerSupported removing the helper in #14, explicitly favored applying the removal component in #19 and committed it.
Replace existing durable_rename_excl() calls with durable_rename()
28 Apr 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #201 of 3 reviewers saw the final version

Matches the caller-conversion component of #20, adding three explanatory comments that the target file should not exist in timeline.c and xlog.c; executable changes are identical.

  • Robert Haassaw an earlier versiontrailerRecommended converting all callers and removing the helper in #2, before the implementation expanded beyond the original WAL patch.
  • Kyotaro Horiguchisaw an earlier versiontrailerReviewed WAL-segment serialization and endorsed durable_rename() in #8, before timeline.c and basic_archive were incorporated.
  • Michael Paquiersaw the final versiontrailerReviewed the expanded approach, supplied the assertion design in #19 and committed the result with explanatory comments.

Credits across 12 commits

Author
Noah Misch1 LLM6
Nathan Bossart4
Kyotaro HoriguchiLLM1
Michael PaquierLLM1
Reviewer
Michael Paquiercommitter10
Kyotaro Horiguchi4
Robert Haas4
Reported by
Arun Thirupathi7
Committer
Michael Paquier11
Noah Misch1

N LLM means N of the credits come from LLM analysis, not from commit trailers.