Jul 2022

3 commits
Fix output of createuser --help with --valid-until
13 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #392 of 2 reviewers saw the final version

The sole src/bin/scripts/createuser.c hunk matches #39 modulo indentation, adding --valid-until=TIMESTAMP and wrapping its description. Michael Paquier confirms the fix in #41.

  • Nathan Bossartsaw the final versiontrailerIn #40, he found #39 reasonable and requested only an indentation correction.
  • Michael Paquiersaw the final versioncommittercommitted the patch
createuser: Add support for more clause types through new options
13 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #353 of 5 reviewers saw the final version

All features and SQL-generation logic from #35 are retained, with options reordered onto the preparatory cleanup and documentation entries repositioned. Committer edits broaden quoting tests to include a spaced ADMIN role name and expiry value, as explained in #38.

  • Nathan Bossartsaw the final versiontrailerHe supported --member in #17, requested tests in #19, supplied corrections in #23, reviewed test revisions in #29 and #32, and accepted #35 in #37.
  • Daniel Gustafssonsaw an earlier versiontrailerHe identified the incompatible --role semantic change in #7; restoring compatibility and fixing expiry-string quoting followed his review of #6.
  • Robert Haassaw an earlier versiontrailerHe supported the proposal in #5 and examined naming and SQL consistency in #10, #12, and #15, before the expiry-string quoting correction.
  • Kyotarosaw the final versiontrailerHe proposed missing clauses in #2, reviewed naming and alignment in #9, reproduced and diagnosed the Windows failure in #33, and discussed quoting coverage for #35 in #36.
  • Michael Paquiersaw the final versioncommittercommitted the patch
createuser: Cleanup and fix internal option ordering
13 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment contains this standalone reordering of long_options, the getopt string, and switch cases in src/bin/scripts/createuser.c. Michael Paquier explains in #38 that he performed the cleanup while preparing the feature for commit.

Credits across 3 commits

Author
Noriyoshi1
Shinoda1
Shinya Kato1
Reviewer
Michael Paquiercommitter2
Nathan Bossart2
Daniel Gustafsson1
Kyotaro1
Robert Haas1
Committer
Michael Paquier3