May 2022

3 commits
pgcrypto: remove questionmark from error message
6 May 2022Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #52 of 2 reviewers saw the final version

The commit preserves the third patch's error-string change in contrib/pgcrypto/px.c from #5 and adds matching expected-output updates in blowfish_1.out, cast5_1.out and des_1.out. Daniel explicitly identified those pending test updates in #5.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom said the patches looked sane in #6, and only matching expected-output updates followed for this change.
  • Michael Paquiersaw the final versionLLM analysis, 97% sureMichael endorsed the pgcrypto cleanups as good catches in #7, before the corresponding expected-output updates were added.
pgcrypto: report init errors as PXE_CIPHER_INIT
6 May 2022Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #52 of 2 reviewers saw the final version

The commit exactly matches the second patch in #5: px_find_digest() returns PXE_CIPHER_INIT for initialization failures, and the unused generic error is removed from contrib/pgcrypto/px.c and px.h.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom reviewed the submitted series and said the patches looked sane in #6.
  • Michael Paquiersaw the final versionLLM analysis, 98% sureMichael discussed the pgcrypto initialization-error reporting and endorsed the cleanups in #7, while suggesting richer diagnostics as future work.
Clear the OpenSSL error queue before cryptohash operations
6 May 2022Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #52 of 2 reviewers saw the final version

The commit matches the first patch in #5 except that its cryptohash initialization comment changes 'FIPS enabled' to 'FIPS-enabled'. Michael requested that correction in #7, and Daniel accepted it in #8.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom requested cleanup after error consumption and explanatory comments in #2, then endorsed the revised patches in #6.
  • Michael Paquiersaw the final versionLLM analysis, 100% sureMichael examined error-queue handling in #4 and reviewed the revision in #7, supplying the comment correction incorporated into the commit.

Credits across 3 commits

Author
Daniel GustafssonLLM3
Committer
Daniel Gustafsson3

N LLM means N of the credits come from LLM analysis, not from commit trailers.