Correct comment in ProcedureCreate() for pgstat_create_function() call.
Sorry, hit the send button too early :|
Attached here !!
Show quoted text
On Fri, May 13, 2022 at 10:20 AM Amul Sul <sulamul@gmail.com> wrote:
Hi,
PFA, attached patch to $SUBJECT.
--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com
Attachments:
code_comment.patchapplication/octet-stream; name=code_comment.patchDownload
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
index d82221fdb8f..9644336dedc 100644
--- a/src/backend/catalog/pg_proc.c
+++ b/src/backend/catalog/pg_proc.c
@@ -710,7 +710,7 @@ ProcedureCreate(const char *procedureName,
AtEOXact_GUC(true, save_nestlevel);
}
- /* ensure that stats are dropped if transaction commits */
+ /* ensure that stats are dropped if transaction aborts */
if (!is_update)
pgstat_create_function(retval);
On Fri, May 13, 2022 at 10:22:57AM +0530, Amul Sul wrote:
Sorry, hit the send button too early :|
- /* ensure that stats are dropped if transaction commits */
+ /* ensure that stats are dropped if transaction aborts */
if (!is_update)
pgstat_create_function(retval);As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right. Will
fix if there are no objections.
--
Michael
On Fri, May 13, 2022 at 04:09:00PM +0900, Michael Paquier wrote:
As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right. Will
fix if there are no objections.
And done with fcab82a. Thanks, Amul.
--
Michael