Jan 2025

2 commits
Add some const decorations (htup.h)
23 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #9

All added and removed lines match the const-decoration component of #9 in src/backend/access/heap/heapam.c, src/backend/utils/time/combocid.c and src/include/access/htup.h.

Convert macros to static inline functions (htup_details.h, itup.h)
23 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #9

The htup_details.h, itup.h and pageinspect conversions match the second component of #9, except HeapTupleHeaderSetTypeId() renames its parameter from typeid to datum_typeid. The experimental generic-selection component is separate and was not included.

Oct 2022

1 commit
Convert macros to static inline functions (rel.h)
7 Oct 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #61 of 1 reviewer saw the final version

The RelationCloseSmgr() conversion from #6 lands with its assertion moved outside the conditional, redundant braces removed and an endif comment added. This follows Amul's suggestion #7, confirmed by Peter #8.

  • Amul Sulsaw the final versiontrailerAmul reviewed #6, proposed moving the assertion outside the conditional and supported retaining inlining #7; those changes were committed.

Jul 2022

7 commits
Convert macros to static inline functions (itup.h)
19 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #40 of 1 reviewer saw the final version

The itup.h component of #4 supplies IndexInfoFindDataOffset() and index_getattr(); the commit additionally excludes index_getattr() from FRONTEND builds. It also carries an intervening index_form_tuple_context() declaration through the prototype relocation and fixes spacing.

  • Amul Sulsaw an earlier versiontrailerAmul reviewed the original series and suggested simplifying conditional returns #2, before the frontend exclusion added to the committed itup.h conversion.
Convert macros to static inline functions (tupmacs.h)
18 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #40 of 1 reviewer saw the final version

The commit takes att_isnull(), fetch_att(), store_att_byval() and the itup.h bitmap cast from #4, but leaves fetchatt() as a macro and omits the associated gistutil.c renaming and pg_attribute.h include. It also adds FRONTEND guards around backend-only helpers.

  • Amul Sulsaw an earlier versiontrailerAmul reviewed #1 and proposed the adopted switch implementation for fetch_att() #2, before the later scope reduction and frontend guards.
Convert macros to static inline functions (xlog_internal.h)
15 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

The xlog_internal.h conversions match #4 with light cleanup: removal of the XLogFileNameById() FIXME, redundant fname parentheses and extra parameter spacing.

  • Amul Sulsaw the final versiontrailerAmul reviewed the original WAL helper conversions and requested declaration spacing in XLogFromFileName() #2, after which only light changes followed.
Convert macros to static inline functions (bufmgr.h)
13 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #40 of 1 reviewer saw the final version

The bufmgr.h component of #4 is retained, with an additional conversion of RelationGetNumberOfBlocks() to a static inline wrapper around RelationGetNumberOfBlocksInFork().

  • Amul Sulsaw an earlier versiontrailerAmul reviewed the original buffer-helper component #2, before RelationGetNumberOfBlocks() was added to the committed scope.
Convert macros to static inline functions (itemptr.h)
13 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

All added and removed lines match the src/include/storage/itemptr.h component of #4, which itself is unchanged from #1.

  • Amul Sulsaw the final versiontrailerAmul said all original components looked good apart from specified minor suggestions elsewhere #2, and the itemptr.h component remained unchanged.
Convert macros to static inline functions (bufpage.h)
11 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #40 of 1 reviewer saw the final version

The bufpage.h component of #4 was expanded with additional page accessors and wrappers, removal of PageIsValid()/PageSizeIsValid(), and caller adjustments in bufpage.c, pg_checksums.c and checksum_impl.h. PageSetPrunable()/PageClearPrunable() remain macros to avoid the access/transam.h dependency.

  • Amul Sulsaw an earlier versiontrailerAmul reviewed the original page conversion and suggested simplifying PageGetMaxOffsetNumber() #2, before substantial additions and the pruning-macro exclusions.
Convert macros to static inline functions (block.h)
7 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

The block.h component matches #4 except for removing redundant parentheses around blockId in BlockIdGetBlockNumber(); the conversions and removal of BlockIdIsValid()/BlockIdCopy() are unchanged.

  • Amul Sulsaw the final versiontrailerAmul reviewed and endorsed the original series #2, and only redundant-parenthesis cleanup followed for block.h.

Credits across 10 commits

Author
Peter EisentrautLLM10
Reviewer
Amul Sul8
Committer
Peter Eisentraut10

N LLM means N of the credits come from LLM analysis, not from commit trailers.