PG15 beta1 fix pg_stat_statements view document

Started by Shinoda, Noriyoshi (PN Japan FSIP)over 3 years ago5 messages

noriyoshi.shinoda@hpe.com

over 3 years ago

1 attachment(s)

Hi hackers,

The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1.
The data type of the following columns in the pg_stat_statements view is bigint in the current document,
but it is actually double precision.
jit_generation_time
jit_inlining_time
jit_optimization_time
jit_emission_time

Regards,
Noriyoshi Shinoda

Attachments:

pg_stat_statements_doc_v1.diffapplication/octet-stream; name=pg_stat_statements_doc_v1.diffDownload

diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index 215419f..2f11dc4 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -413,7 +413,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_generation_time</structfield> <type>bigint</type>
+       <structfield>jit_generation_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on generating JIT code, in milliseconds
@@ -431,7 +431,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_inlining_time</structfield> <type>bigint</type>
+       <structfield>jit_inlining_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on inlining functions, in milliseconds
@@ -449,7 +449,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_optimization_time</structfield> <type>bigint</type>
+       <structfield>jit_optimization_time</structfield> <type>double precisiodouble precision</type>
       </para>
       <para>
        Total time spent by the statement on optimizing, in milliseconds
@@ -467,7 +467,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_emission_time</structfield> <type>bigint</type>
+       <structfield>jit_emission_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on emitting code, in milliseconds

Nathan Bossart

nathandbossart@gmail.com

over 3 years ago

In reply to: Shinoda, Noriyoshi (PN Japan FSIP) (#1)

Re: PG15 beta1 fix pg_stat_statements view document

On Fri, May 20, 2022 at 12:46:03PM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:

The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1.
The data type of the following columns in the pg_stat_statements view is bigint in the current document,
but it is actually double precision.
jit_generation_time
jit_inlining_time
jit_optimization_time
jit_emission_time

I think there is a typo in the change to the jit_optimization_time section,
but otherwise it looks good to me.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Michael Paquier

michael@paquier.xyz

over 3 years ago

In reply to: Nathan Bossart (#2)

Re: PG15 beta1 fix pg_stat_statements view document

On Fri, May 20, 2022 at 04:04:29PM -0700, Nathan Bossart wrote:

I think there is a typo in the change to the jit_optimization_time section,
but otherwise it looks good to me.

Yes, as of "double precisiodouble precision". All these four fields
are indeed doubles in the code, for what looks like a copy-pasto from
57d6aea. Will fix.
--
Michael

Shinoda, Noriyoshi (PN Japan FSIP)

noriyoshi.shinoda@hpe.com

over 3 years ago

In reply to: Michael Paquier (#3)

1 attachment(s)

RE: PG15 beta1 fix pg_stat_statements view document

Hi,

Thank you for your comment.
I attached the fixed patch.

-----Original Message-----
From: Michael Paquier <michael@paquier.xyz>
Sent: Saturday, May 21, 2022 12:33 PM
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>; magnus@hagander.net
Subject: Re: PG15 beta1 fix pg_stat_statements view document

On Fri, May 20, 2022 at 04:04:29PM -0700, Nathan Bossart wrote:

I think there is a typo in the change to the jit_optimization_time
section, but otherwise it looks good to me.

Yes, as of "double precisiodouble precision". All these four fields are indeed doubles in the code, for what looks like a copy-pasto from 57d6aea. Will fix.
--
Michael

Attachments:

pg_stat_statements_doc_v2.diffapplication/octet-stream; name=pg_stat_statements_doc_v2.diffDownload

diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index 215419f..ecf6cd6 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -413,7 +413,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_generation_time</structfield> <type>bigint</type>
+       <structfield>jit_generation_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on generating JIT code, in milliseconds
@@ -431,7 +431,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_inlining_time</structfield> <type>bigint</type>
+       <structfield>jit_inlining_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on inlining functions, in milliseconds
@@ -449,7 +449,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_optimization_time</structfield> <type>bigint</type>
+       <structfield>jit_optimization_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on optimizing, in milliseconds
@@ -467,7 +467,7 @@
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>jit_emission_time</structfield> <type>bigint</type>
+       <structfield>jit_emission_time</structfield> <type>double precision</type>
       </para>
       <para>
        Total time spent by the statement on emitting code, in milliseconds

Michael Paquier

michael@paquier.xyz

over 3 years ago

In reply to: Shinoda, Noriyoshi (PN Japan FSIP) (#4)

Re: PG15 beta1 fix pg_stat_statements view document

On Sat, May 21, 2022 at 03:36:10AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:

Thank you for your comment.
I attached the fixed patch.

Thanks, applied.
--
Michael