Remove an undefined function CalculateMaxmumSafeLSN

Started by Bharath Rupireddyover 3 years ago2 messages
#1Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com
1 attachment(s)

Hi,

While working on a feature, I came across an undefined
(declaration-only) function CalculateMaxmumSafeLSN added by commit
c655077 [1]commit c6550776394e25c1620bc8258427c8f1d448080d Author: Alvaro Herrera <alvherre@alvh.no-ip.org> Date: Tue Apr 7 18:35:00 2020 -0400. Attaching a patch to remove it.

[1]: commit c6550776394e25c1620bc8258427c8f1d448080d Author: Alvaro Herrera <alvherre@alvh.no-ip.org> Date: Tue Apr 7 18:35:00 2020 -0400
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Tue Apr 7 18:35:00 2020 -0400

Allow users to limit storage reserved by replication slots

Regards,
Bharath Rupireddy.

Attachments:

v1-0001-Remove-an-undefined-function-CalculateMaxmumSafeL.patchapplication/octet-stream; name=v1-0001-Remove-an-undefined-function-CalculateMaxmumSafeL.patchDownload
From dec60642c4f7985ffba99011f4d2680ad890559c Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Sat, 21 May 2022 07:18:29 +0000
Subject: [PATCH v1] Remove an undefined function CalculateMaxmumSafeLSN

---
 src/include/access/xlog.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h
index d9f2487a96..cd674c3c23 100644
--- a/src/include/access/xlog.h
+++ b/src/include/access/xlog.h
@@ -233,7 +233,6 @@ extern void ShutdownXLOG(int code, Datum arg);
 extern void CreateCheckPoint(int flags);
 extern bool CreateRestartPoint(int flags);
 extern WALAvailability GetWALAvailability(XLogRecPtr targetLSN);
-extern XLogRecPtr CalculateMaxmumSafeLSN(void);
 extern void XLogPutNextOid(Oid nextOid);
 extern XLogRecPtr XLogRestorePoint(const char *rpName);
 extern void UpdateFullPageWrites(void);
-- 
2.25.1

In reply to: Bharath Rupireddy (#1)
Re:Remove an undefined function CalculateMaxmumSafeLSN

Hello

Yes, I already wrote about this artifact. And created CF app entry so it wouldn't get lost: https://commitfest.postgresql.org/38/3616/

regards, Sergei