PG15 beta1 fix pg_database view document

Started by Shinoda, Noriyoshi (PN Japan FSIP)over 3 years ago3 messages

noriyoshi.shinoda@hpe.com

over 3 years ago

1 attachment(s)

Hi hackers,
Thanks to all the developers. The attached patch updates the manual for the pg_database catalog.
The current pg_database view definition is missing the datlocprovider column. The attached patch adds this column info.
https://www.postgresql.org/docs/15/catalog-pg-database.html

Regards,
Noriyoshi Shinoda

Attachments:

pg_database_doc_v1.diffapplication/octet-stream; name=pg_database_doc_v1.diffDownload

diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index d96c72e..8914886 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -2967,6 +2967,15 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
+       <structfield>datlocprovider</structfield> <type>char</type>
+      </para>
+      <para>
+       Provider of the collation for this database: <literal>c</literal> = libc, <literal>i</literal> = icu
+      </para></entry>
+     </row>
+
+     <row>
+      <entry role="catalog_table_entry"><para role="column_definition">
        <structfield>datistemplate</structfield> <type>bool</type>
       </para>
       <para>

Michael Paquier

michael@paquier.xyz

over 3 years ago

In reply to: Shinoda, Noriyoshi (PN Japan FSIP) (#1)

Re: PG15 beta1 fix pg_database view document

On Mon, May 23, 2022 at 02:00:18AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:

Thanks to all the developers. The attached patch updates the manual
for the pg_database catalog.
The current pg_database view definition is missing the
datlocprovider column. The attached patch adds this column info.
https://www.postgresql.org/docs/15/catalog-pg-database.html

Indeed. I have checked the rest of the catalog headers for any
inconsistencies with the docs and what you have noticed here is the
only one.

+       <structfield>datlocprovider</structfield> <type>char</type>
+      </para>
+      <para>
+       Provider of the collation for this database:
<literal>c</literal> = libc, <literal>i</literal> = icu
+      </para></entry>

ICU needs to be upper-case if you are referring to the library name.
Here, my guess is that you are referring to the value that can be
passed down to the command? You could use lower-case terms like on
the CREATE COLLATION page, but I would put these within a <literal>
markup. Anyway, this formulation is incorrect.
--
Michael

Peter Eisentraut

peter.eisentraut@enterprisedb.com

over 3 years ago

In reply to: Michael Paquier (#2)

Re: PG15 beta1 fix pg_database view document

On 23.05.22 06:25, Michael Paquier wrote:

Indeed. I have checked the rest of the catalog headers for any
inconsistencies with the docs and what you have noticed here is the
only one.

Committed. Thanks for checking.

+       <structfield>datlocprovider</structfield> <type>char</type>
+      </para>
+      <para>
+       Provider of the collation for this database:
<literal>c</literal> = libc, <literal>i</literal> = icu
+      </para></entry>
ICU needs to be upper-case if you are referring to the library name.
Here, my guess is that you are referring to the value that can be
passed down to the command? You could use lower-case terms like on
the CREATE COLLATION page, but I would put these within a <literal>
markup. Anyway, this formulation is incorrect.

This is presumably copied from pg_collation.collprovider, which uses the
same markup. If we want to improve it, they should be changed together.