Sep 2022

2 commits
Split TESTDIR into TESTLOGDIR and TESTDATADIR
20 Sep 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: [RFC] building postgres with meson (part of a posted patchset)
Don't hardcode tmp_check/ as test directory for tap tests
20 Sep 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: [RFC] building postgres with meson (part of a posted patchset)

Jun 2022

2 commits
Force run of pg_upgrade in the build directory in its TAP test
4 Jun 2022Michael Paquiermaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 88% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

The attached versions use TESTDIR or the proposed TESTOUTDIR, whereas the committed unconditional chdir to PostgreSQL::Test::Utils::tmp_check implements Peter's inline alternative and Michael's subsequent agreement #11 #22 #24. The commit also removes obsolete cleanup entries and corrects the post-upgrade dump label.

  • Peter Eisentrautsaw the final versionLLM analysis, 94% surePeter proposed using PostgreSQL::Test::Utils::tmp_check directly, the alternative Michael explicitly credited when committing the fix #11 #24.
  • Tom Lanesaw the final versionLLM analysis, 94% sureTom recommended dropping the infrastructure prerequisite and changing into TESTDIR/tmp_check, which is the directory used by the committed fix #18 #22.
  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres explicitly endorsed Michael's proposal to apply the direct tmp_check fix before resolving the broader directory interface #22 #23.
Add missing test names in TAP tests of pg_upgrade
2 Jun 2022Michael Paquiermaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #161 of 1 reviewer saw the final version

The commit exactly extracts the missing test descriptions and unused getcwd import removal from the pg_upgrade patch in #16, leaving directory handling unresolved #20. Its Author credit names Peter, whose original submission introduced those changes #1.

  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
Andres FreundLLM2
Peter Eisentraut1
Reviewer
Peter Eisentraut2
Tom Lane2
Justin Pryzby1
Michael Paquiercommitter1
Committer
Andres Freund2
Michael Paquier2

N LLM means N of the credits come from LLM analysis, not from commit trailers.