model-writtenrun 7310 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut reported that the pg_upgrade TAP test left delete_old_cluster.sh in the source tree during VPATH builds and proposed changing directories, also adding missing test descriptions #1.
- Michael Paquier revised the patch to use TESTDIR and delay the directory change until immediately before pg_upgrade, because changing directories earlier would prevent pg_regress from finding its regression schedule #2.
- Peter wanted generated files inside tmp_check so normal test cleanup would remove them; Justin Pryzby identified that Peter's TESTOUTDIR variable existed only in Andres Freund's meson branch #3 #5.
- The discussion considered extracting and backpatching the directory infrastructure, but Peter questioned the scope of such a post-beta change and offered a direct chdir to PostgreSQL::Test::Utils::tmp_check; Andres also raised separating test data from logs #9 #11 #13 #14.
- Michael submitted a two-patch series introducing TESTOUTDIR and using it for pg_upgrade; Peter questioned the extra global variable, while Tom Lane objected that the psql changes removed coverage of completion involving directory names #16 #17 #18.
- Andres explained that independently locating test output would help CI and buildfarm collect per-test artifacts, while Michael separated the uncontroversial test-name cleanup into 99f6f19799, using the corresponding portion of #16 and crediting Peter #19 #20.
- Andrew Dunstan reported that the original directory bug apparently caused repeated buildfarm failures, prompting Michael to propose the direct tmp_check fix without waiting for the infrastructure decision; Andres endorsed that plan #21 #22 #23.
- Michael committed the agreed directory change as 15b6d21553, also removing obsolete cleanup entries and correcting a test description, then reported that CI passed #24.
- In August, Andres revived the broader output-directory work with a dedicated subdirectory for completion-test files; Tom supported preserving their relationship to the working directory and suggested naming it tab_comp_dir #25 #26.
- Andres replaced the earlier TESTOUTDIR proposal with three patches: isolate completion files, move the tmp_check suffix into TESTDIR assignments, and split data and log locations; he then corrected variable-name typos and comments #27 #28.
- Tom reviewed the revised series and requested combining or reordering its first two patches so the completion directory would remain under normal cleanup; he left the log-location question dependent on buildfarm support #29.
- At the last exchange, Andrew offered to extend buildfarm log collection and Andres requested support for $dir/log; the June pg_upgrade fixes had landed, while the revised infrastructure patches and any default log-location move remained pending #30 #31.
- The infrastructure subsequently landed through the newer September submission #515855 in thread #44949, which supersedes this thread's #28 for commit attribution: bb54bf2290 combined the completion-directory and TESTDIR changes, and c47885bd8b split data and log locations with the corrected Makefile expansion while retaining the existing buildfarm-facing log locations.