Jun 2025

5 commits
amcheck: Fix posting tree checks in gin_index_check()
17 Jun 2025Tomas Vondramaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #882 of 2 reviewers saw the final version

Takes the posting-tree component of #88; the changed lines in verify_gin.c and t/006_verify_gin.pl match exactly, with the other series components committed separately.

  • Andrey M. Borodinsaw the final versiontrailerReviewed posting-tree validation and suggested additional defensive checking in #86, followed only by test and editorial changes.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
amcheck: Fix parent key check in gin_index_check()
17 Jun 2025Tomas Vondramaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #882 of 2 reviewers saw the final version

Takes the parent-key component of #88, preserving its rightlink condition, GinGetDownlink() correction, and corruption tests without changed-line differences.

  • Andrey M. Borodinsaw the final versiontrailerFound the parent-key patch correct in #86 while questioning test block-number stability; subsequent changes were confined to tests and presentation.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
amcheck: Fix checks of entry order for GIN indexes
17 Jun 2025Tomas Vondramaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #882 of 2 reviewers saw the final version

Combines the entry-order fix and its separate cleanup from #88; applying both to the commit's parent reproduces all three committed files byte-for-byte.

  • Andrey M. Borodinsaw the final versiontrailerReviewed attribute comparisons, root-page checks, rightmost-key handling, and TAP coverage in #86, before test and naming cleanups only.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
amcheck: Remove unused GinScanItem->parentlsn field
17 Jun 2025Tomas Vondramaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #882 of 2 reviewers saw the final version

Extracts the unused-parentlsn component of #88; the field and assignment removals match, apart from context shifts caused by commit ordering.

  • Andrey M. Borodinsaw the final versiontrailerGave the unused-field removal an LGTM in #86, and its implementation remained unchanged.
  • Tomas Vondrasaw the final versioncommittercommitted the patch
amcheck: Test gin_index_check on a multicolumn index
17 Jun 2025Tomas Vondramaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #882 of 2 reviewers saw the final version

Extracts the multicolumn regression-test component of #88; sql/check_gin.sql and expected/check_gin.out have identical changed lines.

  • Andrey M. Borodinsaw the final versiontrailerCalled the additional regression test harmless and useful for coverage in #86, while discussing stronger ways to demonstrate exercised branches.
  • Tomas Vondrasaw the final versioncommittercommitted the patch

Mar 2025

7 commits
Remove incidental md5() function use from test
30 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Replaces md5() with sha256() in the GIN regression input and expected output following Tom Lane's FIPS failure report #75 and Tomas's fix confirmation #76; no attached patch supplies this change.

  • Tom Lanesaw an earlier versionLLM analysis, 92% sureReported the FIPS failure and requested avoiding md5() in #75, before the later corruption-check series ending at #88.
amcheck: Fix indentation in verify_gin.c
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Reflows two comment blocks in verify_gin.c after the feature landing; the commit explanation and #74 identify missed indentation after merging the fix patch, with no matching attached follow-up.

amcheck: Add a test with GIN index on JSONB data
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 96% surepart of a posted patchsetlight changesfrom patchset #722 of 2 reviewers saw the final version

Extracts the JSONB test component announced in #72; its regression SQL and expected-output changes exactly match #64 and #69, with final attachment extraction unavailable.

  • Tomas Vondrasaw the final versiontrailerReviewed and polished the test-bearing series in #72 and committed this component.
  • Kirill Reshkesaw the final versiontrailerInvestigated the JSONB-related failures while revising #64 and explicitly approved the final series in #73.
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 96% surepart of a posted patchsetlight changesfrom patchset #722 of 2 reviewers saw the final version

Extracts the concurrent-index-build test component announced in #72; both TAP-file diffs exactly match its available predecessors in #64 and #69, although the final attachments were not extracted.

  • Tomas Vondrasaw the final versiontrailerReviewed and prepared the final series in #72 and committed this component, which establishes final coverage.
  • Kirill Reshkesaw the final versiontrailerWorked through the test-bearing series in #69 and gave the final submission an LGTM in #73.
amcheck: Add gin_index_check() to verify GIN index
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 91% surepart of a posted patchsetlight changesfrom patchset #722 of 8 reviewers saw the final version

Takes the GIN feature component of #72, combining the implementation and fix from #69; reconstruction shows only comment, naming, logging-level, and typedef-registration differences from that available predecessor. The final attachments are unavailable, and the commit credits Grigory Kryachko, Heikki Linnakangas, and Andrey Borodin.

  • José Villanovasaw an earlier versiontrailerReported compiler warnings, tested deliberate GIN corruption, and checked the revised interface in #11, #14, #18, and #20, before substantial later checking fixes.
  • Aleksander Alekseevsaw an earlier versiontrailerRequested tests demonstrating detection of corrupted indexes in #22, before the later error-handling and GIN correctness revisions.
  • Nikolay Samokhvalovsaw an earlier versiontrailerDiscussed the practical consequences of stopping on corruption in #25 and accepted the distinction between per-index and whole-database checking in #27.
  • Andres Freundsaw an earlier versiontrailerRequested the three-way split in #4 and supplied Meson integration with warning reports in #9, before substantial later GIN changes.
  • Tomas Vondrasaw the final versiontrailerReviewed and stress-tested the implementation, reported false positives, prepared #72, and committed the final feature.
  • Kirill Reshkesaw the final versiontrailerInvestigated and fixed multiple GIN false positives and assertions, then gave #72 an LGTM in #73.
  • Mark Dilgersaw an earlier versiontrailerMeasured coverage and exposed false ordering reports in #64 and #65, but explicitly had not re-reviewed the subsequent attribute-comparison fix in #70.
  • Peter Geoghegansaw an earlier versiontrailerReviewed helper boundaries, concurrency, naming, and error handling in #23 and #24, and supplied the revision in #29 before later GIN fixes.
amcheck: Move common routines into a separate module
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 93% surepart of a posted patchsetlight changesfrom patchset #723 of 8 reviewers saw the final version

Extracts the common-module component of #72; the available predecessor differs only in copyright text, a callback comment, formatting, and BTCallbackState registration in src/tools/pgindent/typedefs.list. The submission explicitly describes these final cleanups, but its attachments were not extracted.

  • José Villanovasaw an earlier versiontrailerReviewed shared-header includes and build warnings in #11 and retested the series in #18, before helper organization and callback changes.
  • Aleksander Alekseevsaw an earlier versiontrailerReviewed the series' test coverage in #22, before the later shared-helper restructuring.
  • Nikolay Samokhvalovno review foundtrailerHis messages support the feature and discuss corruption-reporting behavior, but show no review of the shared locking and security-context refactor.
  • Andres Freundsaw an earlier versiontrailerRequested isolating the refactor in #4 and adapted its build integration in #9, before subsequent helper and callback revisions.
  • Tomas Vondrasaw the final versiontrailerReviewed module naming, common checks, and documentation in #44, then polished and committed the final refactor.
  • Mark Dilgersaw the final versiontrailerReviewed and retained the shared refactor, ran its tests, and measured verify_common.c coverage in #64, after which only light changes followed.
  • Peter Geoghegansaw an earlier versiontrailerDirected which helpers should be shared in #23 and supplied part of that restructuring in #29, before later callback and diagnostic changes.
  • Kirill Reshkesaw the final versiontrailerImplemented the common-module review fixes in #51, maintained the extracted series, and approved its final form in #73.
Fix grammar in GIN README
29 Mar 2025Tomas Vondramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 96% surepart of a posted patchsetlight changesfrom patchset #722 of 2 reviewers saw the final version

Extracts the README grammar component placed first in #72; its three wording replacements exactly match the available attachments from #57 through #69.

  • Mark Dilgersaw the final versionLLM analysis, 100% sureExplicitly said the README component of #58 looked fine in #64, and its wording changes remained unchanged.
  • Tomas Vondrasaw the final versioncommittercommitted the patch

Credits across 12 commits

Author
Arseniy Mukhin5
Andrey Borodin2
Mark Dilger2
Grigory Kryachko1
Heikki Linnakangas1
Kirill Reshke1
Reviewer
Tomas Vondracommitter10
Andrey Borodin5
Kirill Reshke4
Aleksander Alekseev2
Andres Freund2
José Arthur Benetasso Villanova2
Mark Dilger2
Nikolay Samokhvalov2
Peter Geoghegan2
Reported by
Tom Lane1
Committer
Tomas Vondra12