Jun 2022

1 commit
Restructure pg_upgrade output directories for better idempotence
8 Jun 2022Michael Paquiermaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #181 of 2 reviewers saw the final version

4fff78f009 preserves the six-file implementation from #18, but fixes overlapping snprintf input/output in make_outputdirs(), changes the millisecond separator to a dot, and uses pg_malloc0() for directory buffers. It also corrects comments, documentation, and commit prose; #20 confirms the final fixes and application.

  • Daniel Gustafssonsaw an earlier versiontrailerDaniel requested preservation of older logs, readable timestamps, and path-length checks in #13, then endorsed the revised cleanup in #15, before the subsequent timestamp-buffer logic fix.
  • Justin Pryzbysaw the final versiontrailerJustin demonstrated the first patch's remaining retry failure in #10, suggested ISO timestamp formatting in #16, and reviewed the final submitted patch in #19, supplying the buffer-append correction and formatting changes incorporated at commit.

Credits across 1 commit

Author
Michael Paquier1
Reviewer
Daniel Gustafsson1
Justin Pryzby1
Reported by
Tushar Ahuja1
Committer
Michael Paquier1