Jul 2022

2 commits
Improve error reporting from validate_exec().
12 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Kyotaro reported misleading executable-check errors in #3 and proposed inline wording fixes in #4; no attached patch implements this commit's errno handling in src/common/exec.c. Tom explained in #11 that he instead made validate_exec() supply appropriate errno values and used %m in its callers.

  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 95% sureKyotaro demonstrated the misleading diagnostic in #3 and supplied an inline correction in #4, before Tom replaced that approach with shared errno handling in #11.
Remove trailing newlines in pg_upgrade's message strings.
12 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit preserves #1's logging implementation and newline removals, with rebase adjustments, four additional message-string normalizations in check.c and util.c, and two corrected check_exec() diagnostics from #4. Tom confirmed rebasing and adjusting recently added messages in #10.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 100% sureKyotaro examined newline handling in #2 and proposed diagnostic corrections in #4 that were incorporated, and 7652353d87 explicitly credits his review.
  • Peter Eisentrautsaw the final versionLLM analysis, 100% surePeter reported comparing output before and after in several scenarios without problematic differences in #9, and 7652353d87 explicitly credits his review.

Credits across 2 commits

Author
Tom LaneLLM1
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.