Jul 2022

4 commits
Refactor sending of DataRow messages in replication protocol
6 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The DataRow patch in #1 landed with local logic corrections: basebackup_copy.c parses ti->oid with strtoul and removes leftover message construction, while printsimple.c uses pg_ultoa_n with a ten-byte buffer. Peter confirmed cleaning up the posted patch in #3.

  • Nathan Bossartsaw an earlier versiontrailerNathan said all four patches looked reasonable in #2, before the DataRow patch received local logic corrections.
Refactor sending of RowDescription messages in replication protocol
4 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The RowDescription patch in #1 matches the committed changes in tupdesc.c, basebackup_copy.c and walsender.c: OID tuple-descriptor support and replacement of manual RowDescription construction with DestRemoteSimple.

  • Nathan Bossartsaw the final versiontrailerNathan said all four patches looked reasonable in #2, and this patch landed unchanged.
Change timeline field of IDENTIFY_SYSTEM to int8
4 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The IDENTIFY_SYSTEM patch in #1 matches both committed replacements: INT4OID becomes INT8OID in walsender.c and the documented timeline type becomes int8 in protocol.sgml.

  • Nathan Bossartsaw the final versiontrailerNathan said all four patches looked reasonable in #2, and this patch landed unchanged.
Fix attlen in RowDescription of BASE_BACKUP response
4 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The first patch in #1 exactly matches the committed one-line correction in basebackup_copy.c, changing the BASE_BACKUP timeline field's attlen from -1 to 8.

  • Nathan Bossartsaw the final versiontrailerNathan said all four patches looked reasonable in #2, and this patch landed unchanged.

Credits across 4 commits

Author
Peter EisentrautLLM4
Reviewer
Nathan Bossart4
Committer
Peter Eisentraut4

N LLM means N of the credits come from LLM analysis, not from commit trailers.