Comments referring to pg_start/stop_backup

Started by Michael Paquieralmost 4 years ago4 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.

That's not a big deal, but let's be right.

Thanks,
--
Michael

Attachments:

backup_comments.patchtext/x-diff; charset=us-asciiDownload+2-2
#2Kyotaro Horiguchi
horikyota.ntt@gmail.com
In reply to: Michael Paquier (#1)
Re: Comments referring to pg_start/stop_backup

At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in

Hi all,

While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.

That's not a big deal, but let's be right.

+1 and I don't find other instances of the same mistake.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

#3David Steele
david@pgmasters.net
In reply to: Kyotaro Horiguchi (#2)
Re: Comments referring to pg_start/stop_backup

On 6/28/22 01:00, Kyotaro Horiguchi wrote:

At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in

Hi all,

While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.

That's not a big deal, but let's be right.

+1 and I don't find other instances of the same mistake.

Yes, these also look good to me. They are a bit tricky to search for so
I can see how we missed them.

Regards,
-David

#4Michael Paquier
michael@paquier.xyz
In reply to: David Steele (#3)
Re: Comments referring to pg_start/stop_backup

On Tue, Jun 28, 2022 at 07:47:04AM -0400, David Steele wrote:

Yes, these also look good to me. They are a bit tricky to search for so I
can see how we missed them.

Thanks for double-checking. Applied.
--
Michael