Comments referring to pg_start/stop_backup
Hi all,
While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.
That's not a big deal, but let's be right.
Thanks,
--
Michael
Attachments:
backup_comments.patchtext/x-diff; charset=us-asciiDownload
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
index 6eba626420..e23451b0f1 100644
--- a/src/backend/access/transam/xlogrecovery.c
+++ b/src/backend/access/transam/xlogrecovery.c
@@ -716,7 +716,7 @@ InitWalRecovery(ControlFileData *ControlFile, bool *wasShutdown_ptr,
* know how far we need to replay the WAL before we reach consistency.
* This can happen for example if a base backup is taken from a
* running server using an atomic filesystem snapshot, without calling
- * pg_start/stop_backup. Or if you just kill a running primary server
+ * pg_backup_start/stop. Or if you just kill a running primary server
* and put it into archive recovery by creating a recovery signal
* file.
*
diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
index 5244823ff8..95440013c0 100644
--- a/src/backend/replication/basebackup.c
+++ b/src/backend/replication/basebackup.c
@@ -16,7 +16,7 @@
#include <unistd.h>
#include <time.h>
-#include "access/xlog_internal.h" /* for pg_start/stop_backup */
+#include "access/xlog_internal.h" /* for pg_backup_start/stop */
#include "common/compression.h"
#include "common/file_perm.h"
#include "commands/defrem.h"
At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in
Hi all,
While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.That's not a big deal, but let's be right.
+1 and I don't find other instances of the same mistake.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
On 6/28/22 01:00, Kyotaro Horiguchi wrote:
At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in
Hi all,
While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.That's not a big deal, but let's be right.
+1 and I don't find other instances of the same mistake.
Yes, these also look good to me. They are a bit tricky to search for so
I can see how we missed them.
Regards,
-David