Mar 2023

1 commit
Avoid copying undefined data in _readA_Const().
19 Mar 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Alexander Lakhin reported an oversized memcpy in _readA_Const() in #19, and Tom Lane proposed switching on value type in #20. The commit implements that fix in readfuncs.c and tidies _equalA_Const(); no attachment contains these changes.

  • Alexander Lakhinsaw the final versionLLM analysis, 97% sureReported a reproducible Valgrind failure and identified the incorrect union-sized copy introduced by #16, directly prompting the fix in #19.

Sep 2022

7 commits
Implement WRITE_READ_PARSE_PLAN_TREES for raw parse trees
26 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 96% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The pg_parse_query() round-trip check exactly matches #16. It derives from Peter Eisentraut's implementation in #11, with Tom's revision removing the temporary float-output mode.

  • Tom Lanesaw the final versiontrailerRejected the special float-output mode and supplied the final simplified raw-tree checking patch in #16.
Enable WRITE_READ_PARSE_PLAN_TREES of rewritten utility statements
26 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 98% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The postgres.c changes exactly match the rewritten-utility checking patch in #16, including queryId preservation and revised warning text. Tom describes it as essentially Peter Eisentraut's patch from #11.

  • Tom Lanesaw the final versiontrailerReviewed Peter's series, supplied the revised utility-checking patch, and recommended committing it in #16.
Don't lose precision for float fields of Nodes.
26 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The changes to gen_node_support.pl and outfuncs.c exactly match Tom Lane's Ryu-based float-output patch in #16; the commit also explicitly credits Tom as author.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Fix write/read of empty string fields in Nodes.
26 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 2 reviewers saw the final version

The outToken(), outChar(), and nullable_string() changes exactly match Tom Lane's empty-string fix in #16, distinguishing empty strings from NULL without modifying pg_strtok().

  • Andres Freundsaw an earlier versionLLM analysis, 86% sureEndorsed Tom's proposed empty-string encoding in #15 while #11 was under discussion, before its implementation was added in #16.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Add read support for some missing raw parse nodes
24 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The missing-reader patch in #16 has the same stable patch ID as the commit, including token-length checks in readfuncs.c and removal of no_read attributes. Peter supplied the original implementation in #11, which Tom revised and forwarded.

  • Tom Lanesaw the final versiontrailerAdded token-length checks to avoid unsafe comparisons and eliminate ordering dependencies in _readA_Expr() in #16.
Fix reading of BitString nodes
24 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The read.c changes preserving the BitString prefix and recognizing hexadecimal tokens match both #11 and #16 exactly; the latter is the latest matching submission and retains Peter's authorship.

  • Tom Lanesaw the final versiontrailerReviewed the series, explicitly retained this fix unchanged, and recommended committing it in #16.
Fix reading of most-negative integer value nodes
24 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The one-line strtoint(token) to strtoint(numptr) change in read.c matches Peter's patch in both #11 and #16; the latest submission is the source.

  • Tom Lanesaw the final versiontrailerReviewed the series, explicitly retained the integer-tokenization fix unchanged, and recommended committing it in #16.

Credits across 8 commits

Author
Peter EisentrautLLM5
Tom Lane2
Reviewer
Tom Lane5
Peter Eisentrautcommitter2
Committer
Peter Eisentraut7
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.