Jul 2025

1 commit
Make sure IOV_MAX is defined.
1 Jul 2025Tom Lanemaster19beta1REL_19_STABLE19beta1REL_18_STABLE18beta2REL_17_STABLE17.6REL_16_STABLE16.10Also in: GNU/Hurd portability patches (part of a posted patchset)

Feb 2023

1 commit
Doc: Abstract AF_UNIX sockets don't work on Windows.
2 Feb 2023Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.2REL_14_STABLE14.7
LLM analysis, 100% suremodified before commitlight changesfrom patchset #802 of 2 reviewers saw the final version

Makes the same one-line doc/src/sgml/config.sgml correction as #80, with 'Linux only' replacing the attachment's 'Linux'.

  • Andres Freundsaw the final versionLLM analysis, 99% sureReported a concrete Windows 10 client connection failure in #85, confirming the documentation correction.
  • Peter Eisentrautsaw the final versionLLM analysis, 88% sureChallenged the proposed correction in #82 using his earlier Windows testing and distinguished native Windows behavior from WSL.

Jul - Aug 2022

45 commits
Clean up inconsistent use of fflush().
29 Aug 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #951 of 1 reviewer saw the final version

Includes all changes from #95 and adds fflush(NULL) before further popen/system calls throughout backend, frontend and test code, implementing the extension proposed in that message.

  • Thomas Munrosaw the final versionLLM analysis, 97% sureApproved fflush(NULL) and endorsed adding missing pre-subprocess flushes in #96, covering the extension included in the commit.
Remove configure probe for sockaddr_in6 and require AF_INET6.
25 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #901 of 1 reviewer saw the final version

Matches the IPv6 probe and conditional-code removal in #90, with a smaller wording adjustment to the historical address-family comment in src/include/utils/inet.h.

  • Andres Freundsaw the final versiontrailerExplicitly said the remaining IPv6 patch looked good in #93 before it was committed.
Remove configure probes for sockaddr_storage members.
22 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #92

Matches #92, removing four sockaddr_storage member probes and switching src/common/ip.c to HAVE_STRUCT_SOCKADDR_SA_LEN.

mstcpip.h is not missing on MinGW.
18 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81

Takes the complete mstcpip.h component of #81 unchanged, allowing the header on MinGW in pqcomm.c and fe-connect.c.

Remove configure probe for net/if.h.
18 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81

Takes the complete net/if.h component of #81 unchanged, removing its configure probe and redundant include guard in src/backend/libpq/ifaddr.c.

Fix macro problem with gai_strerror on Windows.
18 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81

Takes the complete gai_strerror component of #81 unchanged, removing the conflicting macro manipulations from the Windows netdb.h and sys/socket.h wrappers.

Remove configure probe for netinet/tcp.h.
18 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81

Takes the netinet/tcp.h component of #81, adding an include guard to src/include/port/win32/netinet/tcp.h before landing.

Remove dead ifaddr.c fallback code.
18 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #81

Takes the obsolete Solaris SIOCGLIFCONF implementation removal from #81; because the broader IPv6 patch was held back, the commit also removes the HAVE_IPV6 branches inside the deleted implementation.

Remove configure probe for gethostbyname_r.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #76

Takes the complete gethostbyname_r component newly added in #76, with matching configure.ac, pg_config.h.in and MSVC changes.

Remove replacement code for getaddrinfo.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #761 of 1 reviewer saw the final version

Takes the complete getaddrinfo component of #76, deleting replacement code and adding standard-header usage and the Windows netdb.h wrapper.

  • Tom Lanesaw the final versiontrailerCalled the getaddrinfo cleanup worthwhile and supported pushing it for buildfarm testing in #77.
Remove configure probe for struct sockaddr_storage.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #761 of 1 reviewer saw the final version

Takes the complete sockaddr_storage component of #76, removing its existence probe and replacement structure without additional substantive changes.

  • Tom Lanesaw the final versiontrailerSupported the sockaddr_storage cleanup in #77 after examining the networking series.
Remove HAVE_UNIX_SOCKETS.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #763 of 3 reviewers saw the final version

Takes the HAVE_UNIX_SOCKETS component of #76, adding documentation and comment corrections in libpq.sgml, psql-ref.sgml and pg_regress.c.

  • Tom Lanesaw the final versiontrailerInitially objected in #63, then inspected the guarded code and withdrew his objection in #77.
  • Andres Freundsaw the final versiontrailerExamined Windows Unix-socket behavior and challenged the need to retain the compile-time distinction in #64; subsequent changes split the patch and adjusted documentation.
  • Peter Eisentrautsaw the final versiontrailerExplained why AF_UNIX branches can remain compiled and requested separating macro removal from header cleanup in #68.
Remove configurability of PPC spinlock assembly code.
13 Aug 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #721 of 1 reviewer saw the final version

Matches #72, including removal of PPC configuration switches and the lwarx/ldarx hint and lwsync changes in arch-ppc.h and s_lock.h.

  • Thomas Munrosaw the final versionLLM analysis, 94% sureAssessed the obsolete hardware compatibility concern and supported the newer instruction baseline in #73.
Remove configure probe for sys/select.h.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Takes the complete sys/select.h component of #62, including the Windows stub header and unconditional includes.

  • Tom Lanesaw the final versiontrailerAccepted the header-cleanup series on a readthrough in #63.
Remove configure probes for sys/ipc.h, sys/sem.h, sys/shm.h.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Takes the complete sys/ipc.h, sys/sem.h and sys/shm.h component of #62, with matching probe and include-guard removals.

  • Tom Lanesaw the final versiontrailerAccepted these header-probe removals in his series review at #63.
Remove configure probe for sys/resource.h and refactor.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Takes the sys/resource.h component of #62, additionally removing an obsolete limits.h include and the stale rusagestub.h exception from src/tools/pginclude/headerscheck.

  • Tom Lanesaw the final versiontrailerAccepted the header-cleanup portion of the series in #63; only small include and header-check adjustments followed.
Remove configure probe for shl_load library.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Takes the complete shl_load component of #62, deleting the obsolete library search from configure.ac and generated configure.

  • Tom Lanesaw the final versiontrailerSaid the non-Unix-socket parts of the series looked fine on a readthrough in #63.
Remove configure probes for sys/un.h and struct sockaddr_un.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #623 of 3 reviewers saw the final version

Commits only the sys/un.h and sockaddr_un portion of #62, retaining HAVE_UNIX_SOCKETS as an unconditional definition and deferring removal of its call-site conditionals.

  • Tom Lanesaw the final versiontrailerRequested retaining HAVE_UNIX_SOCKETS while accepting the header cleanup in #63, which is the split implemented by the commit.
  • Peter Eisentrautsaw the final versiontrailerRequested separating the Unix-socket conditional-code removal from the sys/un.h changes in #68.
  • Andres Freundsaw the final versiontrailerReviewed Windows Unix-socket availability and the consequences for testing in #64.
Remove configure probe for sys/uio.h.
13 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Takes the complete sys/uio.h component of #62, including the pg_iovec.h change that limits the fallback IOV_MAX definition to Windows.

  • Tom Lanesaw the final versiontrailerAccepted the header-cleanup series in #63, before the later Hurd report exposed the IOV_MAX assumption.
Fix obsolete comments in instr_time.h.
8 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Matches Thomas Munro's inline replacement of the instr_time.h introductory comment in #60, responding to Tom Lane's report in #59.

  • Tom Lanesaw the final versionLLM analysis, 100% sureReported the obsolete timing explanation in #59 and explicitly accepted the inline correction in #61.
aix: fix misreading of condition in 8f12a4e7add
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements Andres Freund's inline diagnosis in #58, changing the AIX MKLDEXPORT argument in src/backend/Makefile from the installed executable path to '.'.

Rely on __func__ being supported
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #501 of 1 reviewer saw the final version

Takes the complete __func__ component of #50, replacing PG_FUNCNAME_MACRO and deleting its configure machinery.

  • Thomas Munrosaw the final versiontrailerConfirmed __func__ availability against scraped configuration data and the minimum MSVC version in #51.
windows: Remove HAVE_MINIDUMP_TYPE test
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #501 of 1 reviewer saw the final version

Takes the complete Windows minidump component of #50, deleting the probe and always building the crash handler on Windows.

  • Thomas Munrosaw the final versiontrailerReviewed the Windows crash-handler changes and suggested a comment adjustment in #51.
solaris: Remove unnecessary gcc / gnu ld vs sun studio differences
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #501 of 1 reviewer saw the final version

Takes the complete Solaris component of #50, unifying shared-library and runtime-library-path flags in Makefile.solaris and Makefile.shlib.

  • Thomas Munrosaw the final versiontrailerChecked the current manual and explicitly said the Solaris changes looked good in #51.
Trust a few system headers to stand on their own
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #501 of 1 reviewer saw the final version

Takes the complete self-contained-header component of #50, simplifying configure checks for net/if.h, netinet/tcp.h and sys/ucred.h.

  • Thomas Munrosaw the final versiontrailerReviewed the header archaeology and simplification in #51.
aix: Remove checks for very old OS versions
7 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #501 of 1 reviewer saw the final version

Takes the complete AIX component of #50, including the subsequently corrected choice of MKLDEXPORT argument in src/backend/Makefile.

  • Thomas Munrosaw the final versiontrailerReviewed Andres Freund's five-patch cleanup series in #51, including the removal of ancient AIX cases.
Simplify replacement code for strtof.
7 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #451 of 1 reviewer saw the final version

Matches #45, deleting the generic missing-strtof fallback while retaining the pg_strtof wrapper for known buggy implementations.

  • Tom Lanesaw the final versiontrailerSaid the proposed strtof cleanup looked plausible in #47 before it was committed.
Simplify gettimeofday for Windows.
7 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #481 of 1 reviewer saw the final version

Adds the MinGW spelling correction and Assert(tzp == NULL), with its explanatory comment, to #48 as requested in #49.

  • Tom Lanesaw the final versiontrailerReviewed the attachment and supplied the spelling correction and null-tzp assertion incorporated into the commit in #49.
Simplify gettimeofday() fallback logic.
6 Aug 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #352 of 2 reviewers saw the final version

Matches #35 apart from updating the renamed win32gettimeofday.c file's own filename and identification comments.

  • Tom Lanesaw the final versiontrailerApproved the patch and identified its stale filename comments in #38.
  • Thomas Munrosaw the final versiontrailerExplicitly endorsed the gettimeofday changes in #37.
Remove fallbacks for strtoll, strtoull.
5 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #331 of 1 reviewer saw the final version

Matches the revised attachment in #33, whose header and the commit credit Andres Freund; Thomas Munro added the remaining ecpg and timezone macro removals.

  • Thomas Munrosaw the final versiontrailerApproved the original in #29, supplied the missing-reference fixes in #33, and committed the final version.
Remove configure probe for fdatasync.
5 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: Windows now has fdatasync() (not this thread)
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #200 of 2 reviewers saw the final version

Takes the fdatasync component of #20, including the win32fdatasync.c rename, but retains AC_SEARCH_LIBS(fdatasync, [rt posix4]) in configure.ac. This August 3 attachment supersedes the July 22 source #511428 claimed by thread #45231; Thomas Munro explicitly moved the patch here in #19, so that thread's attribution is superseded.

  • Tom Laneno review foundtrailerNo fdatasync-specific review appears in this thread; #25 explicitly addresses clock_gettime, and the fdatasync attachment already carries his review credit from before its transfer.
  • Andres Freundsaw an earlier versiontrailerReviewed the final posted series in #24, before the committer retained the fdatasync library search.
Remove configure probe for clock_gettime.
5 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete clock_gettime component of #20, removing its probe and the gettimeofday timing fallback from instr_time.h.

  • Tom Lanesaw the final versiontrailerReviewed the earlier series and explicitly accepted losing macOS 10.4 clock support in #25.
  • Andres Freundsaw the final versiontrailerReviewed the clock cleanup within the final posted series in #24.
Simplify replacement code for preadv and pwritev.
5 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #201 of 1 reviewer saw the final version

Takes the preadv/pwritev component of #20 and additionally removes unnecessary Windows include conditionals from src/port/preadv.c and src/port/pwritev.c.

  • Andres Freundsaw the final versiontrailerExplicitly supported replacing the lseek/vector fallback with the pread/pwrite loop in #24.
Remove dead pread and pwrite replacement code.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 4 reviewers saw the final version

Takes the pread/pwrite component of #20, using direct pread/pwrite names for the Windows implementations instead of pgwin32_* names plus mapping macros.

  • Tom Lanesaw the final versiontrailerTested the initial series and requested Windows-specific file names in #16; subsequent changes to this component were principally naming and declaration relocation.
  • Greg Starksaw an earlier versiontrailerRead the initial patches and resolved his portability concerns in #5, before the added configure-probe cleanup and Windows-file restructuring.
  • Robert Haassaw an earlier versiontrailerCritiqued the proposed removal of pg_ prefixes in #6, before the additional configure and Windows-specific restructuring.
  • Andres Freundsaw the final versiontrailerDiscussed replacement-function naming in #11 and reviewed the final posted series in #24.
Remove dead setenv, unsetenv replacement code.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #204 of 4 reviewers saw the final version

Takes the complete setenv/unsetenv component of #20, deleting the Unix replacement files, their configure checks and redundant declarations.

  • Tom Lanesaw the final versiontrailerSmoke-tested the initial series in #3 and explicitly found this component acceptable in #16.
  • Greg Starksaw the final versiontrailerRead the initial patches and found his compatibility concerns already addressed in #5; the committed environment cleanup preserves that original change.
  • Robert Haassaw the final versiontrailerApproved the initial components other than pread/pwrite in #6, including the environment-function cleanup.
  • Andres Freundsaw the final versiontrailerReviewed and approved the environment cleanup as part of the final series in #24.
Remove configure probes for poll and poll.h.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete poll component of #20, removing configure probes while retaining HAVE_POLL and HAVE_POLL_H definitions for Unix in port.h.

  • Tom Lanesaw the final versiontrailerRequested preserving descriptive feature macros in #16, which the final poll component implements without changing the intended platform behavior.
  • Andres Freundsaw the final versiontrailerReviewed the final poll cleanup and suggested a possible Windows stub-header alternative in #24.
Remove configure probe for link.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete link component of #20, deleting the probe and renaming the Windows-only implementation to win32link.c.

  • Tom Lanesaw the final versiontrailerRequested the Windows-specific implementation filename in #16, with only naming and build-reference adjustments following.
  • Andres Freundsaw the final versiontrailerReviewed the final link cleanup in #24.
Remove configure probes for symlink/readlink, and dead code.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #201 of 2 reviewers saw the final version

Takes the combined symlink/readlink component of #20, additionally removing obsolete tablespace documentation and correcting comments, including HAVE_READLINE to HAVE_READLINK.

  • Tom Lanesaw an earlier versiontrailerReviewed the earlier series in #16, before the symlink/readlink patches were combined and feature guards distinguished full symlinks from Windows junction support.
  • Andres Freundsaw the final versiontrailerReviewed the combined final symlink/readlink cleanup in #24.
Remove configure probe for setsid.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete setsid component of #20, deleting the configure probe and defining HAVE_SETSID for Unix in port.h.

  • Tom Lanesaw the final versiontrailerSpecifically requested retaining HAVE_SETSID for readability in #16, which is the final implementation.
  • Andres Freundsaw the final versiontrailerReviewed the final version while disagreeing with the retained feature-macro style in #24.
Remove configure probe for shm_open.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete shm_open component of #20, removing the configure probe while retaining the existing call-site guards through a Unix-only HAVE_SHM_OPEN definition.

  • Tom Lanesaw the final versiontrailerRequested keeping descriptive feature guards in #16, and the final shm_open component follows that recommendation.
  • Andres Freundsaw the final versiontrailerReviewed the final configure-cleanup series in #24, including its retained Unix-only feature macros.
Remove configure probe and related tests for getrlimit.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Takes the complete getrlimit component of #20, removing obsolete limit-name checks and the configure probe while retaining HAVE_GETRLIMIT in port.h.

  • Tom Lanesaw the final versiontrailerReviewed the earlier series and requested retaining descriptive feature macros in #16, which the final component does.
  • Andres Freundsaw the final versiontrailerReviewed the final getrlimit cleanup in #24, including the choice to retain a feature macro.
Remove configure probe for dlopen, and refactor.
4 Aug 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #201 of 2 reviewers saw the final version

Takes the complete dlopen component of #20, including Windows-specific file naming, declaration relocation and removal of RTLD_NOW/RTLD_GLOBAL probes.

  • Tom Lanesaw an earlier versiontrailerRequested the Windows-specific file rename in #16, before the patch expanded to remove RTLD declaration probes and reorganize the declarations.
  • Andres Freundsaw the final versiontrailerReviewed the expanded final dlopen component in #24.
Remove dead getpwuid_r replacement code.
23 Jul 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #13 of 3 reviewers saw the final version

Takes the complete getpwuid_r component of #1, removing the probe and obsolete non-reentrant fallback in src/port/thread.c.

  • Tom Lanesaw the final versiontrailerBuilt the entire initial series and reported passing make check on the old macOS host in #3.
  • Greg Starksaw the final versiontrailerRead the patches and found his reentrancy and portability concerns already addressed in #5.
  • Robert Haassaw the final versiontrailerApproved the initial patches other than pread/pwrite in #6.
Remove dead handling for pre-POSIX sigwait().
23 Jul 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #13 of 3 reviewers saw the final version

Takes the complete sigwait component of #1, removing pre-POSIX signature detection and using Windows guards in psql.

  • Tom Lanesaw the final versiontrailerReported successful build and make check testing of the initial series in #3.
  • Greg Starksaw the final versiontrailerRead the initial patches and reported that his compatibility concerns were addressed in #5.
  • Robert Haassaw the final versiontrailerApproved the initial components other than pread/pwrite in #6.
Remove dead getrusage replacement code.
23 Jul 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #10 of 3 reviewers saw the final version

Takes the getrusage component of #1 and additionally removes its configure probe, selects the Windows implementation explicitly and adjusts ShowUsage guards and comments in postgres.c.

  • Tom Lanesaw an earlier versiontrailerTested the original series in #3, before the additional configure and ShowUsage changes.
  • Greg Starksaw an earlier versiontrailerQuestioned Windows getrusage behavior in #4 and found the original patch addressed it in #5, before the additional changes.
  • Robert Haassaw an earlier versiontrailerApproved the original getrusage cleanup in #6, before the broader configure and call-site cleanup.

Credits across 47 commits

Author
Thomas MunroLLM35
Andres Freund6 LLM7
Tom LaneLLM2
Michael Banck1
Reviewer
Tom Lane27
Andres Freund15
Thomas Munro7
Greg Stark5
Robert Haas5
Peter Eisentraut2
Reported by
Tom Lane1
Co author
Christoph Berg1
Committer
Thomas Munro37
Andres Freund7
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.