i.e. and e.g.

Started by Kyotaro Horiguchiover 3 years ago11 messages

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

1 attachment(s)

I happened to see the message below.

WARNING: new data directory should not be inside the old data directory, e.g. %s

The corresponding code is

... the old data directory, e.g. %s", old_cluster_pgdata);

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

fix_pg_upgrade_message.patchtext/x-patch; charset=us-asciiDownload

diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index fda744911d..65cec7bf2b 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -540,7 +540,7 @@ create_script_for_old_cluster_deletion(char **deletion_script_file_name)
 	if (path_is_prefix_of_path(old_cluster_pgdata, new_cluster_pgdata))
 	{
 		pg_log(PG_WARNING,
-			   "\nWARNING:  new data directory should not be inside the old data directory, e.g. %s", old_cluster_pgdata);
+			   "\nWARNING:  new data directory should not be inside the old data directory, i.e. %s", old_cluster_pgdata);
 
 		/* Unlink file in case it is left over from a previous run. */
 		unlink(*deletion_script_file_name);

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#1)

1 attachment(s)

Re: i.e. and e.g.

At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in

I happened to see the message below.

WARNING: new data directory should not be inside the old data directory, e.g. %s

The corresponding code is

... the old data directory, e.g. %s", old_cluster_pgdata);

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

Oops! There's another use of that word in the same context.
Attached contains two fixes.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

fix_pg_upgrade_message_2.patchtext/x-patch; charset=us-asciiDownload

diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index fda744911d..01ede1e4ad 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -540,7 +540,7 @@ create_script_for_old_cluster_deletion(char **deletion_script_file_name)
 	if (path_is_prefix_of_path(old_cluster_pgdata, new_cluster_pgdata))
 	{
 		pg_log(PG_WARNING,
-			   "\nWARNING:  new data directory should not be inside the old data directory, e.g. %s", old_cluster_pgdata);
+			   "\nWARNING:  new data directory should not be inside the old data directory, i.e. %s", old_cluster_pgdata);
 
 		/* Unlink file in case it is left over from a previous run. */
 		unlink(*deletion_script_file_name);
@@ -564,7 +564,7 @@ create_script_for_old_cluster_deletion(char **deletion_script_file_name)
 		{
 			/* reproduce warning from CREATE TABLESPACE that is in the log */
 			pg_log(PG_WARNING,
-				   "\nWARNING:  user-defined tablespace locations should not be inside the data directory, e.g. %s", old_tablespace_dir);
+				   "\nWARNING:  user-defined tablespace locations should not be inside the data directory, i.e. %s", old_tablespace_dir);
 
 			/* Unlink file in case it is left over from a previous run. */
 			unlink(*deletion_script_file_name);

Junwang Zhao

zhjwpku@gmail.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#2)

Re: i.e. and e.g.

make sense.

On Wed, Jul 13, 2022 at 5:14 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:

At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in

I happened to see the message below.

WARNING: new data directory should not be inside the old data directory, e.g. %s

The corresponding code is

... the old data directory, e.g. %s", old_cluster_pgdata);

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

Oops! There's another use of that word in the same context.
Attached contains two fixes.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

--
Regards
Junwang Zhao

Aleksander Alekseev

aleksander@timescale.com

over 3 years ago

In reply to: Junwang Zhao (#3)

Re: i.e. and e.g.

Hi Kyotaro,

Oops! There's another use of that word in the same context.
Attached contains two fixes.

Good catch. I did a quick search for similar messages and apparently
there are no others to fix.

--
Best regards,
Aleksander Alekseev

John Naylor

john.naylor@enterprisedb.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#2)

Re: i.e. and e.g.

On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <

horikyota.ntt@gmail.com> wrote in

I happened to see the message below.

WARNING: new data directory should not be inside the old data

directory, e.g. %s

The corresponding code is

... the old data directory, e.g. %s", old_cluster_pgdata);

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

I did my own quick scan and found one use of i.e. that doesn't really fit,
in a sentence that has other grammatical issues:

-        Due to the differences how ECPG works compared to Informix's
ESQL/C (i.e., which steps
+        Due to differences in how ECPG works compared to Informix's ESQL/C
(namely, which steps
         are purely grammar transformations and which steps rely on the
underlying run-time library)
         there is no <literal>FREE cursor_name</literal> statement in ECPG.
This is because in ECPG,
         <literal>DECLARE CURSOR</literal> doesn't translate to a function
call into

I've pushed that in addition to your changes, thanks!

--
John Naylor
EDB: http://www.enterprisedb.com

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

In reply to: John Naylor (#5)

Re: i.e. and e.g.

At Thu, 14 Jul 2022 09:40:25 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in

On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <

horikyota.ntt@gmail.com> wrote in

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

I did my own quick scan and found one use of i.e. that doesn't really fit,
in a sentence that has other grammatical issues:
-        Due to the differences how ECPG works compared to Informix's
ESQL/C (i.e., which steps
+        Due to differences in how ECPG works compared to Informix's ESQL/C
(namely, which steps
are purely grammar transformations and which steps rely on the

Oh!

I've pushed that in addition to your changes, thanks!

Thanks!

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#6)

Re: i.e. and e.g.

At Thu, 14 Jul 2022 15:38:37 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in

At Thu, 14 Jul 2022 09:40:25 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in
On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <

horikyota.ntt@gmail.com> wrote in

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.". It should be fixed if this is correct. I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

I did my own quick scan and found one use of i.e. that doesn't really fit,
in a sentence that has other grammatical issues:
-        Due to the differences how ECPG works compared to Informix's
ESQL/C (i.e., which steps
+        Due to differences in how ECPG works compared to Informix's ESQL/C
(namely, which steps
are purely grammar transformations and which steps rely on the
Oh!

I've pushed that in addition to your changes, thanks!

Thanks!

By the way, I forgot about back-branches. Don't we need to fix the
same in back-branches?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

John Naylor

john.naylor@enterprisedb.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#7)

Re: i.e. and e.g.

On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

By the way, I forgot about back-branches. Don't we need to fix the
same in back-branches?

The intent of the messages is pretty clear to me, so I don't really see a
need to change back branches. It does make sense for v15, though, and I
just forgot to consider that.

--
John Naylor
EDB: http://www.enterprisedb.com

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

In reply to: John Naylor (#8)

Re: i.e. and e.g.

At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in

On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

By the way, I forgot about back-branches. Don't we need to fix the
same in back-branches?

The intent of the messages is pretty clear to me, so I don't really see a
need to change back branches. It does make sense for v15, though, and I
just forgot to consider that.

Ok, I'm fine with that. Thanks!

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

#10

John Naylor

john.naylor@enterprisedb.com

over 3 years ago

In reply to: Kyotaro Horiguchi (#9)

Re: i.e. and e.g.

On Thu, Jul 21, 2022 at 11:22 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <

john.naylor@enterprisedb.com> wrote in

On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <

horikyota.ntt@gmail.com>

wrote:

By the way, I forgot about back-branches. Don't we need to fix the
same in back-branches?

The intent of the messages is pretty clear to me, so I don't really see

need to change back branches. It does make sense for v15, though, and I
just forgot to consider that.

Ok, I'm fine with that. Thanks!

This is done.

--
John Naylor
EDB: http://www.enterprisedb.com

#11

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 3 years ago

In reply to: John Naylor (#10)

Re: i.e. and e.g.

At Thu, 21 Jul 2022 12:30:04 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in

On Thu, Jul 21, 2022 at 11:22 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:

At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <

john.naylor@enterprisedb.com> wrote in

need to change back branches. It does make sense for v15, though, and I
just forgot to consider that.

Ok, I'm fine with that. Thanks!

This is done.

Thanks!

--
Kyotaro Horiguchi
NTT Open Source Software Center