Jul 2022

2 commits
Feed ObjectAddress to event triggers for ALTER TABLE ATTACH/DETACH
31 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #183 of 4 reviewers saw the final version

Extracts the unchanged partition-address assignments from #18 into src/backend/commands/tablecmds.c, plus two expected-output changes showing the partition descriptions. Michael explicitly confirms the split in #20, and the commit credits Hou as author.

  • Álvaro Herrerano review foundtrailerHis contribution in #15 endorses broader test-helper subcommand coverage, without an identifiable review of the partition-address fix.
  • Amit Kapilasaw the final versiontrailerRequested ATTACH/DETACH coverage in #7 and accepted the testing interface in #12, while the partition-address implementation remained unchanged.
  • Hayato Kurodasaw the final versiontrailerChecked ATExecCmd return-value collection and requested partition tests in #3, reviewing the implementation that ultimately landed unchanged.
  • Michael Paquiersaw the final versiontrailerRequested observable tests in #4, reviewed and expanded the series in #18, and reviewed the final split as committer in #20.
Expand tests of test_ddl_deparse/ for ALTER TABLE
31 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #180 of 3 reviewers saw the final version

Extracts the eight test_ddl_deparse files from #18; the C helper and SQL function definition match exactly, while regression changes add SET LOGGED/UNLOGGED and adjust descriptions to NULL before the partition fix. The backend changes were separated or dropped as explained in #20.

  • Álvaro Herrerasaw an earlier versiontrailerEndorsed extending the test-helper work from #11 to omitted subcommands in #15, before further cases and switch handling were added.
  • Amit Kapilasaw an earlier versiontrailerProposed partition subcommand tests in #7, discussed the helper interface in #9, and accepted #11 in #12 before subsequent implementation expansion.
  • Hayato Kurodasaw an earlier versiontrailerIdentified missing partition tests in #3 and supported using test_ddl_deparse in #6, before the new helper and expanded command handling were implemented.

Credits across 2 commits

Author
Hou, Zhijie2
Michael Paquier1
Reviewer
Alvaro Herrera2
Amit Kapila2
Hayato Kuroda (Fujitsu)2
Michael Paquier1
Committer
Michael Paquier2