model-writtenrun 5339 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Zhijie Hou proposed collecting the ObjectAddress already returned by partition attach, index attach, detach, and detach-finalize operations so event triggers could identify the affected partition #1.
- Hayato Kuroda checked the missing return-value assignments and requested partition tests, with Michael Paquier agreeing; Hou explained that the SQL event-trigger interface did not expose these subcommand addresses, making test_ddl_deparse the appropriate testing location #3 #4 #5 #6.
- Amit Kapila proposed adding missing partition subcommand recognition, and Michael proposed returning subcommand types and object descriptions as rows; after discussing compatibility, Amit accepted changing the test-module function itself #7 #8 #9 #10 #12.
- Michael supplied the new test helper and partition tests alongside Hou's unchanged fix, and the participants settled on replacing the old array-returning helper #11 #13.
- Hou found additional missing subcommands and supplied a follow-up attachment, Álvaro Herrera supported covering them, and Michael recommended removing the switch default so compiler warnings would expose future omissions; Hou incorporated that advice into the expanded three-patch series #14 #15 #16 #17.
- Michael consolidated the series and expanded coverage from roughly 32% to 64%, including proposed address returns for RLS and relation options, while deferring constraint validation and deletion, SET ACCESS METHOD testing, and DROP COLUMN handling because their object-address behavior needed more thought #18.
- Hou questioned the usefulness of returning the relation itself for RLS and relation options, and Michael agreed to remove those changes, add further tests, and split the testing improvements from the partition fix #19 #20.
- The testing portion of #18 landed first as 07ff701dbd, retaining the new helper and missing subcommand handling, adding SET LOGGED/UNLOGGED tests, and reporting NULL descriptions where backend address changes had been omitted.
- The unchanged partition-address assignments from #18 then landed separately as 43231423da, with expected output updated to show the attached and detached partition descriptions.
- Michael announced both commits and Hou acknowledged completion; the partition fix and selected testing improvements were finished, with the broader address-handling cases left for possible future patches #20 #21.