Nov 2022

2 commits
Remove code handling FORCE_NULL and FORCE_NOT_NULL for COPY TO
2 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #13 of 3 reviewers saw the final version

The committed 46-line deletion in src/backend/commands/copyto.c has the same stable patch ID as #1, differing only in base context. Michael Paquier explicitly rejected the assertions added in later submissions in #9, returning to the original patch's scope.

  • Richard Guosaw the final versiontrailerRichard confirmed the original code was unreachable in #3, requested additional assertions in #5, and accepted their omission in #10.
  • Kyotaro Horiguchisaw the final versiontrailerKyotaro endorsed the original deletion in #2, then corrected list comparisons and questioned the redundant assertions in #7.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Add more tests for COPY with incorrect option combinations
2 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

This commit adds eight invalid-option cases to src/test/regress/sql/copy2.sql and corresponding expected output; none of the four attached patchsets contains tests. Michael Paquier identifies it in #12 as additional coverage he added while working on the cleanup.

Credits across 2 commits

Author
Zhang Mingli1
Reviewer
Kyotaro Horiguchi1
Michael Paquiercommitter1
Richard Guo1
Committer
Michael Paquier2