Should fix a comment referring to stats collector?
Hi,
Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there
was a comment referring 'statistics collector' in pg_statistic.h.
Note that since the arrays are variable-size, K may be chosen by the
statistics collector.
Should it be modified to 'cumulative statistics system' like manual on
monitoring stats[1]https://www.postgresql.org/docs/current/monitoring-stats.html?
Its title has changed from 'statistics collector' to 'cumulative
statistics system'.
[1]: https://www.postgresql.org/docs/current/monitoring-stats.html
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
Attachments:
v1-0001-Modified-a-comment-referring-to-stats-collector.patchtext/x-diff; name=v1-0001-Modified-a-comment-referring-to-stats-collector.patchDownload+3-4
On 2022-Jul-29, torikoshia wrote:
Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was
a comment referring 'statistics collector' in pg_statistic.h.Note that since the arrays are variable-size, K may be chosen by the
statistics collector.Should it be modified to 'cumulative statistics system' like manual on
monitoring stats[1]?
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Maybe it should just say "K may be chosen at ANALYZE time".
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Nadie está tan esclavizado como el que se cree libre no siéndolo" (Goethe)
On 2022-07-30 02:53, Alvaro Herrera wrote:
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Thanks for the explanation!
Maybe it should just say "K may be chosen at ANALYZE time".
It seems clearer than current one.
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote:
On 2022-07-30 02:53, Alvaro Herrera wrote:
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.Thanks for the explanation!
Maybe it should just say "K may be chosen at ANALYZE time".
It seems clearer than current one.
Change made in master.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian <bruce@momjian.us> wrote:
On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote:
On 2022-07-30 02:53, Alvaro Herrera wrote:
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.Thanks for the explanation!
Maybe it should just say "K may be chosen at ANALYZE time".
It seems clearer than current one.
Change made in master.
I believe some redundant wording has been committed.
K may be chosen may be chosen at ANALYZE time.
Attached patch fixes it and with some line adjustments.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.comOnly you can decide what is important to you.
--
Regards
Junwang Zhao
Attachments:
v1-0001-remove-redundant-wording-in-pg_statistic.h.patchapplication/octet-stream; name=v1-0001-remove-redundant-wording-in-pg_statistic.h.patchDownload+3-4
On Sat, Dec 28, 2024 at 03:25:46PM +0800, Junwang Zhao wrote:
I believe some redundant wording has been committed.
K may be chosen may be chosen at ANALYZE time.
Attached patch fixes it and with some line adjustments.
Indeed. Fixed, thanks!
--
Michael