Mar 2023

1 commit
Revise pg_pwrite_zeros()
6 Mar 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #592 of 2 reviewers saw the final version

The committed batching loop, static-const buffer, and selective iovec initialization match Andres's #59, with size/offset arguments reordered and comments clarified. Michael explicitly confirms choosing that version over #63 in #70.

  • Michael Paquiersaw the final versiontrailerCompared both implementations, tested them on tmpfs, and committed Andres's version with reordered arguments #64 #70.
  • Bharath Rupireddysaw the final versiontrailerCompared initialization costs and benchmarked both alternatives before endorsing Andres's implementation with the argument-order correction #63 #69.

Oct - Nov 2022

3 commits
Use pg_pwrite_zeros() in walmethods.c
8 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #425 of 5 reviewers saw the final version

Takes only the src/bin/pg_basebackup/walmethods.c portion of #42, preserving its logic while shortening the lseek() comment and adjusting whitespace. Michael confirms the split and comment-only refinements in #43 and #46.

  • Nathan Bossartsaw the final versiontrailerReviewed errno handling and Windows positioning, requested unconditional lseek(), and approved the resulting version, after which this caller received only light changes #11 #14 #27 #30.
  • Andres Freundsaw the final versiontrailerRejected caller-supplied zero buffers and reviewed the replacement design, leaving the committed walmethods.c call unchanged apart from formatting and comments #33 #37.
  • Thomas Munrosaw the final versiontrailerCorrected short-write error handling, investigated Windows file-position changes, and endorsed unconditional lseek(), which the final caller retains #4 #15 #28.
  • Michaelsaw the final versiontrailerThis wrapped trailer names committer Michael Paquier, who reviewed the final submission and split it into commits with shortened comments #43 #46.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Introduce pg_pwrite_zeros() in fileutils.c
8 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #423 of 5 reviewers saw the final version

Takes the file_utils.c, file_utils.h, and xlog.c portions of #42, leaving walmethods.c for a separate commit. The helper's logic matches, with shortened comments and formatting changes described in #46.

  • Nathan Bossartsaw an earlier versiontrailerReviewed buffer types, errno handling, and the sparse-file byte write and approved the earlier series, before the helper's buffer interface and eventual PGAlignedBlock dependency were revised #11 #14 #30.
  • Andres Freundsaw the final versiontrailerOpposed passing buffers from callers and adding another aligned-block type, leading directly to the committed PGAlignedBlock design #33 #37 #43.
  • Thomas Munrosaw an earlier versiontrailerReviewed helper naming, size arguments, buffer sizing, partial-block handling, and portability before the later buffer-interface revisions #4 #7 #15 #28.
  • Michaelsaw the final versiontrailerThis wrapped trailer names committer Michael Paquier, who selected the PGAlignedBlock design and committed the helper after final review and comment cleanup #43.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Move pg_pwritev_with_retry() to src/common/file_utils.c
27 Oct 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #293 of 3 reviewers saw the final version

Commits the relocation component of #29, moving pg_pwritev_with_retry() and its declaration from backend storage files into common/file_utils.c and its header. The implementation is unchanged, with a lightly revised function comment; #31 confirms only this component landed.

  • Nathan Bossartsaw the final versiontrailerExplicitly approved the relocation component and later approved the updated series, with only rebasing and comment changes affecting the moved function #11 #30.
  • Thomas Munrosaw the final versiontrailerEndorsed moving pg_pwritev_with_retry() into common code and requested separating that mechanical move into its own patch #4.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Sep 2022

1 commit
Restore pg_pread and friends.
29 Sep 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Restores pg_ prefixes and documents Windows file-position side effects, implementing Thomas's proposal #18 and the unindexed text attachment in #21. No indexed patchset contains this restoration; Bharath requested the added source comments in #22.

  • Bharath Rupireddysaw the final versiontrailerApproved the unindexed restoration attachment and requested Windows implementation comments that Thomas agreed to add before committing #22 #23.

Credits across 5 commits

Author
Bharath Rupireddy3
Andres Freund1
Reviewer
Michael Paquiercommitter4
Nathan Bossart3
Thomas Munro3
Andres Freund2
Bharath Rupireddy2
Michael2
Reported by
Bharath Rupireddy1
Committer
Michael Paquier4
Thomas Munro1