Remove dummyret definition

Started by Peter Eisentrautover 3 years ago2 messages
#1Peter Eisentraut
peter.eisentraut@enterprisedb.com
1 attachment(s)

dummyret hasn't been used in a while (last use removed by 50d22de932,
and before that 84b6d5f359), and since we are now preferring inline
functions over complex macros, it's unlikely to be needed again.

Attachments:

0001-Remove-dummyret-definition.patchtext/plain; charset=UTF-8; name=0001-Remove-dummyret-definition.patchDownload
From 513c41d4a79cad768d5ead3366a43def2b3e272b Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Wed, 17 Aug 2022 07:22:34 +0200
Subject: [PATCH] Remove dummyret definition

This hasn't been used in a while (last use removed by 50d22de932, and
before that 84b6d5f359), and since we are now preferring inline
functions over complex macros, it's unlikely to be needed again.
---
 src/include/c.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/include/c.h b/src/include/c.h
index 65e91a6b89..dfc366b026 100644
--- a/src/include/c.h
+++ b/src/include/c.h
@@ -333,16 +333,6 @@
 	_61,_62,_63,  N, ...) \
 	(N)
 
-/*
- * dummyret is used to set return values in macros that use ?: to make
- * assignments.  gcc wants these to be void, other compilers like char
- */
-#ifdef __GNUC__					/* GNU cc */
-#define dummyret	void
-#else
-#define dummyret	char
-#endif
-
 /*
  * Generic function pointer.  This can be used in the rare cases where it's
  * necessary to cast a function pointer to a seemingly incompatible function
-- 
2.37.1

#2Daniel Gustafsson
daniel@yesql.se
In reply to: Peter Eisentraut (#1)
Re: Remove dummyret definition

On 17 Aug 2022, at 07:26, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:

dummyret hasn't been used in a while (last use removed by 50d22de932, and before that 84b6d5f359), and since we are now preferring inline functions over complex macros, it's unlikely to be needed again.

+1, I can't see that making a comeback into the code.

--
Daniel Gustafsson https://vmware.com/