Aug 2022

3 commits
Add more detail why repalloc and pfree do not accept NULL pointers
28 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 97% surewritten from the discussion, no matching patch0 of 3 reviewers saw the final version

805a397db4 changes only src/backend/utils/mmgr/README, retaining the prohibition on NULL and explaining memory-context requirements and performance concerns. This documentation-only resolution was not attached as a patchset and is explicitly confirmed in #8.

  • Tom Lanesaw an earlier versionLLM analysis, 90% sure#2 identified back-patching hazards in the proposed behavior change, helping establish the decision subsequently documented, but did not review the final documentation.
  • Andres Freundsaw an earlier versionLLM analysis, 95% sure#3 identified the cost of adding branches for known non-NULL pointers, a concern incorporated into the final documentation after the implementation proposal was abandoned.
  • David Rowleysaw an earlier versionLLM analysis, 98% sure#5 tested the proposed pfree() change and reported approximately 2.6% slowdown, substantiating the performance rationale subsequently documented.
Remove unneeded null pointer checks before PQfreemem()
26 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

e890ce7a4f takes only the PQfreemem() component of #1, with an identical stable patch ID across its three files. The additional pg_recvlogical.c changes supplied in #4 are absent.

  • Tom Lanesaw the final versiontrailer#2 explicitly found the PQfreemem() cleanup acceptable, and that component landed unchanged.
Remove unnecessary casts in free() and pfree()
26 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

45987aae26 takes only the cast-removal component of #1, with an identical stable patch ID. Its seven substitutions in contrib/sepgsql/label.c and src/backend/utils/fmgr/dfmgr.c are unchanged.

  • Tom Lanesaw the final versiontrailer#2 explicitly raised no objection to the cast-removal patch, which landed unchanged.

Credits across 3 commits

Author
Peter EisentrautLLM2
Reviewer
Tom Lane2
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.