xml2: add test for coverage
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46467psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 05:43 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t46467_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t46467_1 && git checkout t46467_1Patchset v1 (message #1) is on t46467_1
Hi, hackers
I made a small patch for xml2 to improve test coverage.
However, there was a problem using the functions below.
- xpath_number
- xpath_bool
- xpath_nodeset
- xpath_list
Do you have any advice on how to use this function correctly?
It would also be good to add an example of using the function to the document.
---
Regards,
DongWook Lee.
On 23.08.22 03:38, Dong Wook Lee wrote:
I made a small patch for xml2 to improve test coverage.
However, there was a problem using the functions below.- xpath_number
- xpath_bool
- xpath_nodeset
- xpath_listDo you have any advice on how to use this function correctly?
It would also be good to add an example of using the function to the document.
I can confirm that these functions could use more tests and more
documentation and examples. But given that you registered a patch in
the commit fest, it should be you who provides a patch to solve those
issues. Are you still working on this, or were you just looking for
help on how to solve this?
On Fri, 25 Nov 2022 at 18:08, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
On 23.08.22 03:38, Dong Wook Lee wrote:
I made a small patch for xml2 to improve test coverage.
However, there was a problem using the functions below.- xpath_number
- xpath_bool
- xpath_nodeset
- xpath_listDo you have any advice on how to use this function correctly?
It would also be good to add an example of using the function to the document.I can confirm that these functions could use more tests and more
documentation and examples. But given that you registered a patch in
the commit fest, it should be you who provides a patch to solve those
issues. Are you still working on this, or were you just looking for
help on how to solve this?
Hi DongWook Lee,
Are you planning to work on this and provide an updated patch, if you
are not planning to work on it, we can update the commitfest entry
accordingly.
Regards,
Vignesh
On Tue, 17 Jan 2023 at 17:06, vignesh C <vignesh21@gmail.com> wrote:
On Fri, 25 Nov 2022 at 18:08, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:On 23.08.22 03:38, Dong Wook Lee wrote:
I made a small patch for xml2 to improve test coverage.
However, there was a problem using the functions below.- xpath_number
- xpath_bool
- xpath_nodeset
- xpath_listDo you have any advice on how to use this function correctly?
It would also be good to add an example of using the function to the document.I can confirm that these functions could use more tests and more
documentation and examples. But given that you registered a patch in
the commit fest, it should be you who provides a patch to solve those
issues. Are you still working on this, or were you just looking for
help on how to solve this?Hi DongWook Lee,
Are you planning to work on this and provide an updated patch, if you
are not planning to work on it, we can update the commitfest entry
accordingly.
There has been no updates on this thread for some time, so this has
been switched as Returned with Feedback. Feel free to open it in the
next commitfest if you plan to continue on this.
Regards,
Vignesh