Sep 2022

2 commits
postgres_fdw: Remove useless DO block in test
16 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #7

Matches the complete DO-block cleanup component of #7: two insertions and twelve deletions in contrib/postgres_fdw/sql/postgres_fdw.sql and its expected output. The other component is excluded, and differences in surrounding hint text are rebase context.

Adjust assorted hint messages that list all valid options.
16 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #161 of 5 reviewers saw the final version

Retains all ten changed paths and the matching logic from #16, removing “to reference” from four hint strings and their expected output, and formatting ClosestMatchState in src/include/utils/varlena.h. Peter confirms the wording edit in #17.

  • Ibrar Ahmedsaw an earlier versionLLM analysis, 78% sureIn #4, he advocated suppressing the growing invalid-option hint, an approach adopted in #7 before the closest-match rework.
  • Robert Haassaw an earlier versionLLM analysis, 94% sureIn #5, he argued that exhaustive option lists belong in documentation, prompting their removal in #7 before closest-match suggestions were introduced.
  • Tom Lanesaw an earlier versionLLM analysis, 100% sureHe identified the other affected validators in #6, requested shared matching logic and a threshold in #9, and exposed poor suggestions in #13, leading to the matching-rule changes in #14.
  • Michael Paquiersaw an earlier versionLLM analysis, 93% sureIn #12, he objected to adding Levenshtein calculations to error paths and preferred simple hint removal; the subsequent version changed the matching rules.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Nathan Bossart1
Peter EisentrautLLM1
Reviewer
Peter Eisentrautcommitter1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.