model-writtenrun 5075 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed centralizing libpq error translation and newline insertion in a helper, supplying an incomplete conversion to resolve inconsistent message strings during development and translation #1.
- Andres Freund questioned symbol visibility while investigating build failures #2 #4; Peter wanted the helper available across libpq source files without exposing it to users #3, and Tom Lane agreed that this should work while identifying unsafe variadic retry handling and recommending caller-owned retry loops #5 #6.
- Andres traced the build failures to the helper being inside ENABLE_NLS #7, and Peter posted a corrected version while deferring the other issues #9.
- Peter completed the work as separate API and call-site conversion patches, introducing both buffer and connection helpers and fixing the retry loops #10; he explained that SSL tests exposed invalid va_list reuse when a long private-key permission error exceeded the initial buffer size #11.
- Alvaro Herrera reviewed the APIs and sampled the conversions, supporting the approach while requesting clearer translation documentation and comments explaining separately appended newlines; he also suggested translating the format string only once #12.
- Peter accepted the comment changes but retained translation inside the retry loop because moving it might interfere with compiler format checking and most messages never retry #13; Alvaro accepted that reasoning in the final thread reply #14.
- Both patches from #10 landed on November 15: the API infrastructure as 0873b2d354 with documentation edits, and the conversions as a9e9a9f32b with explanatory comments, formatting, and rebase adjustments; no submitted portion remained outstanding.