model-writtenrun 5225 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Gustafsson proposed removing the unused restrictedToken variable and assignment from pg_regress, questioning whether they were a copy-and-paste mistake and attaching the cleanup in #1.
- Nathan Bossart endorsed the patch in #2, and Michael Paquier agreed that the variable looked accidental while asking whether CreateRestrictedProcess() should return INVALID_HANDLE_VALUE on failure in #3.
- Nathan explained that returning zero likely followed CreateProcess() conventions and permitted a boolean-style failure check in #4.
- Andrew Dunstan recommended keeping the existing return convention and using a boolean test in pg_regress instead in #5.
- Daniel committed the patch from #1 with that boolean-style adjustment as f863d82b2f and confirmed it was pushed in #6, completing the proposed cleanup.