model-writtenrun 5184 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Gustafsson proposed moving six overlooked pg_upgrade diagnostic files from the working directory into the internal output subdirectory in #1.
- Tom Lane supported consistent placement provided error messages identify the files' paths in #2; Daniel confirmed existing precedent and proposed clarifying the documentation while retaining generated scripts in the working directory for compatibility in #3.
- Justin Pryzby confirmed that scripts should stay in the working directory while diagnostic files should move, and submitted Daniel's unchanged patch together with a refactoring to centralize path construction in check_for_data_types_usage() in #4.
- Michael Paquier checked pg_upgrade for other omissions and approved the original fix in #5, but rejected the refactoring because callers still needed file paths for error reporting; Daniel agreed to let him commit in #6.
- Michael committed only the first patch from #4 unchanged as ee5353abb6, with a backpatch through PostgreSQL 15, and confirmed completion in #7; the refactoring was left out and the proposed documentation clarification remained unaddressed in this thread.