Sep 2022

1 commit
Remove useless pstrdups in untransformRelOptions
13 Sep 2022Alvaro Herreramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The commit exactly matches Alvaro Herrera's inline patch removing both pstrdup calls in untransformRelOptions #7. It does not apply the attached patch's pfree(s) addition #1; the original allocation instead supplies both strings.

  • Daniel Gustafssonsaw the final versionLLM analysis, 88% sureDaniel questioned the practical impact of the reported allocation and requested a case where repeated transformations would accumulate significant memory, reviewing the sole attached patch #2 #1; the committed replacement was inline #7.
  • Tom Lanesaw the final versionLLM analysis, 99% sureTom questioned the unnecessary pstrdup and explained why adding individual frees was unwarranted, motivating the committed inline replacement #3 #5 #7.

Credits across 1 commit

Reported by
Junwang Zhao1
Committer
Alvaro Herrera1