Oct 2022

1 commit
pgstat: Prevent stats reset from corrupting slotname by removing slotname
8 Oct 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.0
LLM analysis, 100% suremodified before commitlight changesfrom patchset #250 of 2 reviewers saw the final version

Five of the six file diffs match #25 exactly; src/include/pgstat.h only loses the branch-selection FIXME comments and conditional unused slotname field, implementing the announced master variant. 06dbd619bf also lightly polishes the commit message and contains no tests.

  • Masahiko Sawadasaw an earlier versiontrailerIn #22, he endorsed direct slot-name lookup and questioned the need for pgstat_acquire_replslot(), before #25 added the accessor and corrected missing-entry creation.
  • Kyotaro Horiguchisaw an earlier versiontrailerHe identified the wrong field restored by #4 in #5 and validated the lifetime and initialization assumptions of #21 in #23, before the accessor and entry-creation changes in #25.

Credits across 1 commit

Author
Andres Freund1
Reviewer
Kyotaro Horiguchi1
Masahiko Sawada1
Reported by
Jaime Casanova1
Committer
Andres Freund1