Fix typos in code comments

Started by houzj.fnst@fujitsu.comover 3 years ago7 messages

over 3 years ago

1 attachment(s)

Hi,

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.

Best regards,
Hou zhijie

Attachments:

0001-fix-typos.patchapplication/octet-stream; name=0001-fix-typos.patchDownload

From 220df9e8ec36a478d69b6500c106ea51cf7a0caf Mon Sep 17 00:00:00 2001
From: "houzj.fnst" <houzj.fnst@cn.fujitsu.com>
Date: Wed, 7 Sep 2022 11:06:12 +0800
Subject: [PATCH] fix typos

---
 src/backend/catalog/pg_attrdef.c          |  2 +-
 src/backend/replication/logical/decode.c  | 12 ++++++------
 src/test/regress/expected/foreign_key.out |  2 +-
 src/test/regress/sql/foreign_key.sql      |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/backend/catalog/pg_attrdef.c b/src/backend/catalog/pg_attrdef.c
index c5d4a99..a47f61a 100644
--- a/src/backend/catalog/pg_attrdef.c
+++ b/src/backend/catalog/pg_attrdef.c
@@ -334,7 +334,7 @@ RemoveAttrDefaultById(Oid attrdefId)
 
 /*
  * Get the pg_attrdef OID of the default expression for a column
- * identified by relation OID and and column number.
+ * identified by relation OID and column number.
  *
  * Returns InvalidOid if there is no such pg_attrdef entry.
  */
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
index ea8a216..0b12ae0 100644
--- a/src/backend/replication/logical/decode.c
+++ b/src/backend/replication/logical/decode.c
@@ -126,7 +126,7 @@ LogicalDecodingProcessRecord(LogicalDecodingContext *ctx, XLogReaderState *recor
 }
 
 /*
- * Handle rmgr XLOG_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr XLOG_ID records for LogicalDecodingProcessRecord().
  */
 void
 xlog_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
@@ -169,7 +169,7 @@ xlog_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
 }
 
 /*
- * Handle rmgr XACT_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr XACT_ID records for LogicalDecodingProcessRecord().
  */
 void
 xact_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
@@ -326,7 +326,7 @@ xact_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
 }
 
 /*
- * Handle rmgr STANDBY_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr STANDBY_ID records for LogicalDecodingProcessRecord().
  */
 void
 standby_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
@@ -372,7 +372,7 @@ standby_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
 }
 
 /*
- * Handle rmgr HEAP2_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr HEAP2_ID records for LogicalDecodingProcessRecord().
  */
 void
 heap2_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
@@ -432,7 +432,7 @@ heap2_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
 }
 
 /*
- * Handle rmgr HEAP_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr HEAP_ID records for LogicalDecodingProcessRecord().
  */
 void
 heap_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
@@ -554,7 +554,7 @@ FilterByOrigin(LogicalDecodingContext *ctx, RepOriginId origin_id)
 }
 
 /*
- * Handle rmgr LOGICALMSG_ID records for DecodeRecordIntoReorderBuffer().
+ * Handle rmgr LOGICALMSG_ID records for LogicalDecodingProcessRecord().
  */
 void
 logicalmsg_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
diff --git a/src/test/regress/expected/foreign_key.out b/src/test/regress/expected/foreign_key.out
index da26f08..f9092d5 100644
--- a/src/test/regress/expected/foreign_key.out
+++ b/src/test/regress/expected/foreign_key.out
@@ -2440,7 +2440,7 @@ DELETE FROM pt;
 DELETE FROM ref;
 ABORT;
 DROP TABLE pt, ref;
--- Multi-level partitioning at at referenced end
+-- Multi-level partitioning at referenced end
 CREATE TABLE pt(f1 int, f2 int, f3 int, PRIMARY KEY(f1,f2))
   PARTITION BY LIST(f1);
 CREATE TABLE pt1_2 PARTITION OF pt FOR VALUES IN (1, 2) PARTITION BY LIST (f1);
diff --git a/src/test/regress/sql/foreign_key.sql b/src/test/regress/sql/foreign_key.sql
index 725a59a..6e1fddb 100644
--- a/src/test/regress/sql/foreign_key.sql
+++ b/src/test/regress/sql/foreign_key.sql
@@ -1742,7 +1742,7 @@ DELETE FROM pt;
 DELETE FROM ref;
 ABORT;
 DROP TABLE pt, ref;
--- Multi-level partitioning at at referenced end
+-- Multi-level partitioning at referenced end
 CREATE TABLE pt(f1 int, f2 int, f3 int, PRIMARY KEY(f1,f2))
   PARTITION BY LIST(f1);
 CREATE TABLE pt1_2 PARTITION OF pt FOR VALUES IN (1, 2) PARTITION BY LIST (f1);
-- 
2.7.2.windows.1

Amit Kapila

amit.kapila16@gmail.com

over 3 years ago

In reply to: houzj.fnst@fujitsu.com (#1)

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 8:14 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.

Thanks, the patch looks good to me. I'll push this.

--
With Regards,
Amit Kapila.

Zhang Mingli

zmlpostgres@gmail.com

over 3 years ago

In reply to: Amit Kapila (#2)

Re: Fix typos in code comments

Hi
On Sep 19, 2022, 10:57 +0800, Amit Kapila <amit.kapila16@gmail.com>, wrote:

On Mon, Sep 19, 2022 at 8:14 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.

Thanks, the patch looks good to me. I'll push this.

--
With Regards,
Amit Kapila.

Good catch. There is a similar typo in doc, runtime.sgml.

```using TLS protocols enabled by by setting the parameter```

Justin Pryzby

pryzby@telsasoft.com

over 3 years ago

In reply to: Zhang Mingli (#3)

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 02:44:12AM +0000, houzj.fnst@fujitsu.com wrote:

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.

Thanks.

On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:

Good catch. There is a similar typo in doc, runtime.sgml.
```usingï¿½TLSï¿½protocols enabledï¿½by byï¿½setting the parameter```

That one should be backpatched to v15.

Find below some others.

diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 901dd435efd..160296e1daf 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -2155,7 +2155,7 @@ InitPartitionPruneContext(PartitionPruneContext *context,
  * Current values of the indexes present in PartitionPruneState count all the
  * subplans that would be present before initial pruning was done.  If initial
  * pruning got rid of some of the subplans, any subsequent pruning passes will
- * will be looking at a different set of target subplans to choose from than
+ * be looking at a different set of target subplans to choose from than
  * those in the pre-initial-pruning set, so the maps in PartitionPruneState
  * containing those indexes must be updated to reflect the new indexes of
  * subplans in the post-initial-pruning set.
diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c
index 6224c498c21..5b0f26e3b07 100644
--- a/src/backend/utils/activity/pgstat.c
+++ b/src/backend/utils/activity/pgstat.c
@@ -556,7 +556,7 @@ pgstat_initialize(void)
  * suggested idle timeout is returned. Currently this is always
  * PGSTAT_IDLE_INTERVAL (10000ms). Callers can use the returned time to set up
  * a timeout after which to call pgstat_report_stat(true), but are not
- * required to to do so.
+ * required to do so.
  *
  * Note that this is called only when not within a transaction, so it is fair
  * to use transaction stop time as an approximation of current time.
diff --git a/src/backend/utils/activity/pgstat_replslot.c b/src/backend/utils/activity/pgstat_replslot.c
index b77c05ab5fa..9a59012a855 100644
--- a/src/backend/utils/activity/pgstat_replslot.c
+++ b/src/backend/utils/activity/pgstat_replslot.c
@@ -8,7 +8,7 @@
  * storage implementation and the details about individual types of
  * statistics.
  *
- * Replication slot stats work a bit different than other other
+ * Replication slot stats work a bit different than other
  * variable-numbered stats. Slots do not have oids (so they can be created on
  * physical replicas). Use the slot index as object id while running. However,
  * the slot index can change when restarting. That is addressed by using the
diff --git a/src/test/ssl/t/SSL/Server.pm b/src/test/ssl/t/SSL/Server.pm
index 62f54dcbf16..0a9e5da01e4 100644
--- a/src/test/ssl/t/SSL/Server.pm
+++ b/src/test/ssl/t/SSL/Server.pm
@@ -257,7 +257,7 @@ The certificate file to use. Implementation is SSL backend specific.

=item keyfile => B<value>

-The private key to to use. Implementation is SSL backend specific.
+The private key file to use. Implementation is SSL backend specific.

=item crlfile => B<value>

Import Notes

Reply to msg id not found: b4f38c78-577a-4438-baa5-a252e8160804@SparkOS0PR01MB57162559C01FE2848C12E8F7944D9@OS0PR01MB5716.jpnprd01.prod.outlook.com | Resolved by subject fallback

David Rowley

dgrowleyml@gmail.com

over 3 years ago

In reply to: Justin Pryzby (#4)

Re: Fix typos in code comments

On Mon, 19 Sept 2022 at 23:10, Justin Pryzby <pryzby@telsasoft.com> wrote:

Find below some others.

Thanks. Pushed.

David

Justin Pryzby

pryzby@telsasoft.com

over 3 years ago

In reply to: Justin Pryzby (#4)

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:

On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:

Good catch. There is a similar typo in doc, runtime.sgml.
```usingï¿½TLSï¿½protocols enabledï¿½by byï¿½setting the parameter```

That one should be backpatched to v15.

This is still needed -- "by by"

--
Justin

Amit Kapila

amit.kapila16@gmail.com

over 3 years ago

In reply to: Justin Pryzby (#6)

Re: Fix typos in code comments

On Sat, Sep 24, 2022 at 4:00 AM Justin Pryzby <pryzby@telsasoft.com> wrote:

On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:

On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:

Good catch. There is a similar typo in doc, runtime.sgml.
```using TLS protocols enabled by by setting the parameter```

That one should be backpatched to v15.

This is still needed -- "by by"

Thanks for the reminder. I have pushed the fix.

--
With Regards,
Amit Kapila.