Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46637psql -h localhost -U postgresBuilt from patchset v2 (message #2), October 06, 2026 at 11:38 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t46637_2 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t46637_2 && git checkout t46637_2Patchset v2 (message #2) is on t46637_2
Hi hacker,
As $subject detailed, the tab-complete cannot work such as:
CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
It seems that the get_previous_words() could not parse the single quote.
OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Tue, 20 Sep 2022 at 00:19, Japin Li <japinli@hotmail.com> wrote:
Hi hacker,
As $subject detailed, the tab-complete cannot work such as:
CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
It seems that the get_previous_words() could not parse the single quote.
OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
Attach fixed this problem. Any thoughts?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli@hotmail.com> wrote:
Hi hacker,
As $subject detailed, the tab-complete cannot work such as:
CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
It seems that the get_previous_words() could not parse the single quote.
OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
I reviewed the Patch and it looks fine to me.
Thanks and Regards,
Shubham Khanna.
On Tue, 26 Dec 2023 at 18:10, Shubham Khanna <khannashubham1197@gmail.com> wrote:
On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli@hotmail.com> wrote:
Hi hacker,
As $subject detailed, the tab-complete cannot work such as:
CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
It seems that the get_previous_words() could not parse the single quote.
OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
I reviewed the Patch and it looks fine to me.
Thanks for the review.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.