Nov 2022

1 commit
psql: Improve tab completion for GRANT/REVOKE
18 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #111 of 3 reviewers saw the final version

Combines both patches from #11 in src/bin/psql/tab-complete.c but omits their ALL PRIVILEGES hunks. It also renames the shared privilege macro and adjusts REVOKE matching and role completion, consistent with the committer's explanation in #12.

  • Kyotaro Horiguchisaw an earlier versiontrailerIn #3, he reviewed the initial patch and discussed the invalid GRANT suggestion, before the subsequent GRANT/REVOKE implementation and revisions.
  • Michael Paquiersaw the final versiontrailerHe identified incorrect role completion and duplicated privilege lists in #10, then reviewed, simplified, merged, and committed the final patches as reported in #12.
  • Peter Smithsaw an earlier versiontrailerHe reported the GRANT anomaly in #2, tested its fix in #6, and confirmed ALL PRIVILEGES completion in #9, before the later logic revisions and removal of that handling.

Sep 2022

1 commit
Fix tab-completion after commit 790bf615ddba
30 Sep 2022Alvaro Herreramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15rc2
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #41 of 2 reviewers saw the final version

The diff exactly matches the first patch of #4, including all changes to tab-complete.c, tablesync.c, and 031_column_list.pl; the separate GRANT/REVOKE patch was left pending. Alvaro Herrera confirms committing only the first patch in #5.

  • Peter Smithsaw an earlier versiontrailerHe tested and endorsed #1 in #2, before #4 changed the FOR TABLES and FOR ALL TABLES completion logic.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
shiy.fnst@fujitsu.com2
Reviewer
Peter Smith2
Alvaro Herreracommitter1
Kyotaro Horiguchi1
Michael Paquier1
Committer
Alvaro Herrera1
Michael Paquier1