Oct 2022

4 commits
Remove Abs()
12 Oct 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The six-line deletion of Abs() from src/include/c.h exactly matches the fourth attached patch in #1, apart from rebased line positions.

  • Zhang Minglisaw the final versiontrailerZhang supported the original series in #2, and its macro-removal patch landed unchanged.
  • Tom Lanesaw the final versiontrailerTom accepted the series apart from its int64 handling in #3, covering the unchanged macro removal.
Use C library functions instead of Abs() for int64
10 Oct 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 2 reviewers saw the final version

The second attached patch in #1 was revised to call i64abs(), retain long long formatting casts, and define a HAVE_LONG_INT_64-dependent labs()/llabs() wrapper in src/include/c.h. This implements Tom Lane’s proposal in #3.

  • Zhang Minglisaw an earlier versiontrailerZhang supported the initial series in #2, before the int64 wrapper replaced its direct llabs() calls.
  • Tom Lanesaw an earlier versiontrailerTom requested a type-dependent int64 wrapper in #3, but the supplied thread contains no review of the resulting implementation.
Use fabsf() instead of Abs() or fabs() where appropriate
8 Oct 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #21 of 2 reviewers saw the final version

The commit combines Peter Eisentraut’s complete third patch from #1 with Zhang Mingli’s float4abs() conversion from #2. The supplemental formatting.c and selfuncs.c conversions were omitted.

  • Zhang Minglisaw the final versiontrailerZhang reviewed the original fabsf() changes and supplied the additional float4abs() conversion in #2, covering all changes that landed.
  • Tom Lanesaw an earlier versiontrailerTom accepted the original fabsf() patch in #3, but did not explicitly review Zhang’s additional float4abs() conversion.
Remove unnecessary uses of Abs()
7 Oct 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

All changes across 26 files match the first attached patch in #1, replacing Abs() with abs()/fabs() and adjusting includes and casts; normalized diffs are identical.

  • Zhang Minglisaw the final versiontrailerZhang supported the original series in #2, and this component landed unchanged.
  • Tom Lanesaw the final versiontrailerTom accepted the series except for its separate int64 component in #3, covering these unchanged abs()/fabs() replacements.

Credits across 4 commits

Author
Peter EisentrautLLM4
Reviewer
Tom Lane4
Zhang Mingli4
Committer
Peter Eisentraut4

N LLM means N of the credits come from LLM analysis, not from commit trailers.