[PATCH] Improve tab completion for ALTER TABLE on identity columns

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:

Hi Hackers,

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

Added to the next commit fest:

https://commitfest.postgresql.org/40/3947/

- ilmari

Hi Hackers,

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

In passing, I also added completion for ALTER SEQUECNE … START, which was
missing for some reason.

- ilmari

Hi ilmari

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience
hackers has anything more to say about these patches, but at first they
seem correct to me.

--
Matheus Alcantara

On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

Added to the next commit fest:

https://commitfest.postgresql.org/40/3947/

Committed.

On 26.10.22 00:45, Matheus Alcantara wrote:

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

In passing, I also added completion for ALTER SEQUECNE … START, which was
missing for some reason.

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience
hackers has anything more to say about these patches, but at first they
seem correct to me.

This was sensible for a first review. Thanks for you help.

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

Added to the next commit fest:
https://commitfest.postgresql.org/40/3947/

Committed.

Thanks!

- ilmari