possible typo for CREATE PUBLICATION description
Hi,
I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.
Best Regards,
Takamichi Osumi
Attachments:
v1-0001-modify-a-typo.patchapplication/octet-stream; name=v1-0001-modify-a-typo.patchDownload
From 4c71197613c72d2417d4fedf789739edd1bead7b Mon Sep 17 00:00:00 2001
From: Takamichi Osumi <osumi.takamichi@fujitsu.com>
Date: Thu, 13 Oct 2022 06:05:33 +0000
Subject: [PATCH v1] modify a typo
---
doc/src/sgml/ref/create_publication.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/create_publication.sgml b/doc/src/sgml/ref/create_publication.sgml
index c5190f0..cf75e3b 100644
--- a/doc/src/sgml/ref/create_publication.sgml
+++ b/doc/src/sgml/ref/create_publication.sgml
@@ -295,7 +295,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
<para>
For an <command>INSERT ... ON CONFLICT</command> command, the publication will
publish the operation that actually results from the command. So depending
- of the outcome, it may be published as either <command>INSERT</command> or
+ on the outcome, it may be published as either <command>INSERT</command> or
<command>UPDATE</command>, or it may not be published at all.
</para>
--
1.8.3.1
On Thu, Oct 13, 2022 at 6:16 PM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
Hi,
I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.
Your typo correction LGTM.
FWIW, maybe other parts of that paragraph can be tidied too. e.g. The
words "actually" and "So" didn't seem needed IMO.
~
BEFORE
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that actually results from the command. So depending on
the outcome, it may be published as either INSERT or UPDATE, or it may
not be published at all.
SUGGESTION
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that results from the command. Depending on the outcome,
it may be published as either INSERT or UPDATE, or it may not be
published at all.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
Hello
On 2022-Oct-13, osumi.takamichi@fujitsu.com wrote:
I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.
Yeah, looks good. It actually applies all the way back to 10, so I
pushed it to all branches. I included Peter's wording changes as well.
Thanks
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)
Hi, Alvaro-san
On Thursday, October 13, 2022 8:38 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2022-Oct-13, osumi.takamichi@fujitsu.com wrote:
I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.Yeah, looks good. It actually applies all the way back to 10, so I pushed it to
all branches. I included Peter's wording changes as well.Thanks
You are right and thank you so much for taking care of this !
Best Regards,
Takamichi Osumi