Nov 2022

2 commits
libpq: Handle NegotiateProtocolVersion message
17 Nov 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #51 of 2 reviewers saw the final version

The commit preserves the three-file implementation from #5, but changes parser EOF handling from polling to error_return and fixes PQExpBuffer cleanup on early exits. These local logic changes address Jacob Champion's report in #8 and the agreed adjustment in #11.

  • Jacob Championsaw the final versiontrailerJacob identified missing length checks in #4, tested malformed messages and found a buffer leak in #8, and endorsed the final EOF-handling adjustment in #12.
  • Nathan Bossartsaw an earlier versiontrailerNathan corrected version comparison and diagnostic behavior in #2, before subsequent changes to message-length validation, EOF handling, and buffer cleanup.
libpq: Correct processing of startup response messages
17 Nov 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The src/interfaces/libpq/fe-connect.c change exactly implements Peter Eisentraut's inline patch in #11, replacing authentication-request EOF polling with goto error_return. No attached patchset contains this change, and the commit credits Jacob Champion as its reporter.

  • Jacob Championsaw the final versionLLM analysis, 100% sureJacob proposed treating EOF as an error after the complete message was buffered in #10 and endorsed the inline fix in #12, while noting that the authentication case might be unreachable.

Credits across 2 commits

Author
Peter EisentrautLLM1
Reviewer
Jacob Champion1
Nathan Bossart1
Reported by
Jacob Champion1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.