Outdated comments in AssignTransactionId?
Started by Japin Liabout 3 years ago1 messages
The AssignTransactionId has the following comments:
/*
* ensure this test matches similar one in
* RecoverPreparedTransactions()
*/
if (nUnreportedXids >= PGPROC_MAX_CACHED_SUBXIDS ||
log_unknown_top)
{
...
}
However, RecoverPreparedTransactions removes this reference in 49e9281549.
Attached remove this reference in AssignTransactionId.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
Attachments:
remove-outdated-comment-in-AssignTransactionId.patchtext/x-diffDownload
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index fd5103a78e..fe0cf5527b 100644
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -741,10 +741,6 @@ AssignTransactionId(TransactionState s)
unreportedXids[nUnreportedXids] = XidFromFullTransactionId(s->fullTransactionId);
nUnreportedXids++;
- /*
- * ensure this test matches similar one in
- * RecoverPreparedTransactions()
- */
if (nUnreportedXids >= PGPROC_MAX_CACHED_SUBXIDS ||
log_unknown_top)
{