Jan 2023

2 commits
Fix tab completion of ALTER FUNCTION/PROCEDURE/ROUTINE ... SET SCHEMA.
6 Jan 2023Dean Rasheedmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.2REL_14_STABLE14.7REL_13_STABLE13.10+2 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Dean Rasheed identifies the pre-existing SET SCHEMA completion bug in #9 and announces its separate fix and backpatch in #12. The commit adds !TailMatches("SCHEMA") to the generic ALTER ... SET handler in src/bin/psql/tab-complete.c; none of the attachments contains this change.

Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE.
6 Jan 2023Dean Rasheedmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #93 of 4 reviewers saw the final version

Applying #9 to the commit's parent, after removing the attachment's erroneous new-file metadata, produces src/bin/psql/tab-complete.c byte-for-byte identical to the committed file. Dean Rasheed supplied the final revision of vignesh C's patch, and the commit explicitly credits Vignesh C.

  • Dong Wook Leesaw an earlier versionLLM analysis, 100% sureTested #1 and identified missing SET and RESET support in #2, prompting new completion logic in #3.
  • Michael Paquiersaw the final versionLLM analysis, 99% sureProposed shared option lists and caught a trailing space in #4 while reviewing #3, after which only refactoring, formatting and rebasing followed.
  • Melih Mutlusaw the final versionLLM analysis, 100% sureSuggested a function-options macro when reviewing #5 in #6 and reported successful testing of #7 in #8, with only readability changes following.
  • Dean Rasheedsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
vignesh CLLM1
Reviewer
Dean Rasheedcommitter1
Committer
Dean Rasheed2

N LLM means N of the credits come from LLM analysis, not from commit trailers.