Feb 2023

2 commits
Remove stray duplicated comment in heapam.h
8 Feb 2023David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Deletes the duplicated rs_numblocks comment in src/include/access/heapam.h reported by Melanie in #24 and acknowledged by David in #25. The deletion is absent from the attached follow-up in #23.

  • Melanie Plagemansaw the final versionLLM analysis, 100% sureWhile reviewing #23, she identified the duplicated comment in #24, directly prompting the committed deletion.
More refactoring of heapgettup() and heapgettup_pagemode()
7 Feb 2023David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #161 of 2 reviewers saw the final version

Matches the final loop-refactoring patch in #16, rebased over the separately landed helpers and rs_coffset field. Edits clarify comments and key tests, remove redundant casts, and retain caller-owned rs_inited assignments as explained in #23.

  • Andres Freundsaw an earlier versiontrailerReviewed the original refactoring in #3, questioning tuple-offset extraction, initialization, locking, and goto usage before later changes to scan-state handling and helper responsibilities.
  • David Rowleysaw the final versiontrailerReviewed successive versions in #12 and #15, benchmarked #16 in #17, revised the helpers, and reviewed the final code as committer.

Jan 2023

1 commit
Run pgindent on heapam.c
23 Jan 2023David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #101 of 1 reviewer saw the final version

Includes all eight formatting hunks from the preliminary pgindent patch in #10, plus a blank line in heap_delete and three additions to src/tools/pgindent/typedefs.list. David explicitly describes these additions in #12.

  • David Rowleysaw the final versioncommittercommitted the patch

Jan 2023

1 commit
Push lpp variable closer to usage in heapgetpage()
2 Jan 2023Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #62 of 2 reviewers saw the final version

Matches the standalone heapgetpage cleanup in #6, moving lpp into the loop and replacing nested normal-item processing with an early continue. The commit moves the lpp declaration ahead of the other loop locals and adjusts formatting.

  • Andres Freundsaw the final versionLLM analysis, 81% sureReviewed the original combined heap-scan cleanup in #3; its heapgetpage loop transformation survived into this extracted patch with only naming and declaration-layout changes.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Nov 2022

4 commits
Variable renaming in preparation for refactoring
16 Nov 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #42 of 2 reviewers saw the final version

Extracts the page-to-block and dp-to-page renaming from the larger refactor in #4, as confirmed in #5. The committer also applies the naming cleanup to heap_hot_search_buffer, bitmap-scan code in heapam_handler.c, and the heapgetpage declaration.

  • Andres Freundsaw the final versionLLM analysis, 100% sureIdentified the confusing BlockNumber page and Page dp names in #3 and proposed the preliminary renaming implemented in #4.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Turn HeapKeyTest macro into inline function
16 Nov 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #42 of 2 reviewers saw the final version

Takes the HeapKeyTest inline conversion and both caller updates from #4, with header-order and formatting edits. The same submitted patch's catcache.c include removal was split into c0f1e51ac7.

  • Andres Freundsaw the final versiontrailerReviewed the inline conversion in #3, calling it a readability improvement and noting redundant parentheses; subsequent changes were limited to headers, formatting, and splitting the include cleanup.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Remove unused include
16 Nov 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #41 of 1 reviewer saw the final version

Exactly extracts the one-line removal of access/valid.h from src/backend/utils/cache/catcache.c contained in the HeapKeyTest patch of #4. The function conversion landed separately.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Remove redundant breaks in HeapTupleSatisfiesVisibility
5 Nov 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

Exactly matches the first patch in #4: seven unreachable break statements removed from HeapTupleSatisfiesVisibility in src/backend/access/heap/heapam_visibility.c.

  • Andres Freundsaw the final versioncommittercommitted the patch

Credits across 8 commits

Author
Melanie Plageman1 LLM7
Reviewer
Peter Eisentrautcommitter4
Andres Freundcommitter3
David Rowleycommitter2
Reported by
Melanie Plageman1
Committer
Peter Eisentraut4
David Rowley3
Andres Freund1

N LLM means N of the credits come from LLM analysis, not from commit trailers.