Dec 2022

1 commit
Add palloc_aligned() to allow aligned memory allocations
22 Dec 2022David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #170 of 3 reviewers saw the final version

The commit takes the eight-file allocator implementation from #17, whose header credits Andres Freund consistently with #1, but omits the explicitly non-committable src/backend/optimizer/plan/planner.c test. Beyond comments and naming, it changes AlignedAllocRealloc() in src/backend/utils/mmgr/alignedalloc.c to calculate copy size using PallocAlignedExtraBytes() and a checking assertion, matching the commit announcement #18.

  • Maxim Orlovsaw an earlier versiontrailerMaxim reported that the original patch looked good and supplied regression tests in #2, before subsequent context, Valgrind, sentinel, and repalloc logic changes.
  • Andres Freundsaw an earlier versiontrailerAndres reviewed allocator organization, resizing, alignment, and Valgrind concerns in #3 and proposed the adopted overhead reduction in #14, before the final repalloc calculation changed.
  • John Naylorsaw an earlier versiontrailerJohn proposed the adopted InitCatCache() conversion in #6 and examined resizing, alignment special-casing, and the relaxed chunk-offset assertion in #10, before subsequent allocator logic changes.

Credits across 1 commit

Author
Andres Freund1
David Rowley1
Reviewer
Andres Freund1
John Naylor1
Maxim Orlov1
Committer
David Rowley1