Nov 2022

3 commits
Remove unneeded includes of <sys/stat.h>
5 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

2a71de8915 removes unused <sys/stat.h> includes from rewriteheap.c, copydir.c and pgtz.c, extending the cleanup discussed in this thread. Michael identifies these three additional files in #9; no attached patch covers them.

Remove outdated include
4 Nov 2022John Naylormaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

233cf6e8ad deletes <sys/stat.h> from guc-file.l rather than relocating it as in #1. Michael questions its necessity in #5 and reports successful CI without it in #7, leading to John's removal.

  • Michael Paquiersaw the final versionLLM analysis, 99% sureMichael identified the unnecessary include in #5 and reported successful CI with it removed in #7, before the removal commit.
Straighten include order in guc-file.l
3 Nov 2022John Naylormaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

Both hunks of 062eef3a9b match #1, moving <sys/stat.h> from among PostgreSQL headers to between <ctype.h> and <unistd.h> in guc-file.l.

  • Julien Rouhaudsaw the final versionLLM analysis, 100% sureJulien endorsed the patch and identified the original oversight in #2, and the commit explicitly credits his review.
  • John Naylorsaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Michael PaquierLLM1
Reviewer
John Naylorcommitter1
Committer
John Naylor2
Michael Paquier1

N LLM means N of the credits come from LLM analysis, not from commit trailers.