Dec 2025

1 commit
Fix a race condition in updating procArray->replication_slot_xmin.
30 Dec 2025Masahiko Sawadamaster19beta1REL_19_STABLE19beta1REL_18_STABLE18.2REL_17_STABLE17.8REL_16_STABLE16.12REL_15_STABLE15.16REL_14_STABLE14.21
LLM analysis, 95% suremodified before commitlight changesfrom patchset #673 of 7 reviewers saw the final version

The branch-specific submission in #67 is the latest source; the commit's executable changes in logical.c and slot.c match the corresponding changes in #66. Its comments incorporate Chao Li's corrections from #68, which Sawada agreed to apply in #69; the final attachments are unavailable for exact comparison.

  • Masahiko Sawadasaw the final versiontrailerExamined concurrent xmin regression and crash safety, requested explanatory comments in #65, approved the update in #67, and committed the final version.
  • Amit Kapilasaw the final versiontrailerReproduced the race and reviewed locking and backbranch API details, then endorsed the final shared-lock approach in #57, after which only light changes followed.
  • Pradeep Kumarsaw an earlier versiontrailerReported the missing slot-synchronization lock in #45 and supplied its fix in #47, before the later change to shared locking for aggregation.
  • Hayato Kuroda (Fujitsu)saw an earlier versiontrailerRequested an exclusive-mode lock assertion in #19 and independently reproduced and explained the invalid-xmin failure in #20, before the locking approach was reworked.
  • Robert Haassaw an earlier versiontrailerQuestioned the contention assumptions and proposed preventing xmin retreat while discussing the earlier patch's commit message in #41, before the final locking design was settled.
  • Andres Freundsaw an earlier versiontrailerIdentified ProcArrayLock contention and proposed reversing lock acquisition and extending ReplicationSlotControlLock coverage in #35, prompting substantial subsequent changes.
  • Chao Lisaw the final versiontrailerSaid the master patch looked solid and supplied three comment corrections in #68, which were incorporated before commitment.

Nov 2022

1 commit
Add additional checks while creating the initial decoding snapshot.
21 Nov 2022Amit Kapilamaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #142 of 2 reviewers saw the final version

The complete diff matches #14 after removing git index metadata, including the snapbuild.c checks and walsender.c read-only requirement. Amit Kapila confirmed pushing it in #16.

  • Andres Freundsaw the final versionLLM analysis, 100% sureProposed the diagnostic and snapshot-safety checks, refined their placement, and approved the final patch in #15; the commit also explicitly credits his review.
  • Amit Kapilasaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Amit Kapila based on suggestions by Andres Freund1
Zhijie Hou (Fujitsu)1
Reviewer
Amit Kapilacommitter2
Andres Freund1
Chao Li1
Hayato Kuroda (Fujitsu)1
Masahiko Sawada1
Pradeep Kumar1
Robert Haas1
Committer
Amit Kapila1
Masahiko Sawada1