Remove unused param rte in set_plain_rel_pathlist

Started by Zhang Mingliover 3 years ago2 messageshackers
Jump to latest
#1Zhang Mingli
zmlpostgres@gmail.com

Hi, hackers

Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all.

I look at the commit e2fa76d80b(10 years ago), it’s useless since then.

Add a path to remove it.

Regards,
Zhang Mingli

Attachments:

v1-0001-Remove-unused-param-rte-in-set_plain_rel_pathlist.patchapplication/octet-streamDownload+4-5
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zhang Mingli (#1)
Re: Remove unused param rte in set_plain_rel_pathlist

Zhang Mingli <zmlpostgres@gmail.com> writes:

Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all.
Add a path to remove it.

I'm disinclined to change that, as it'd make set_plain_rel_pathlist
different from its sibling functions, which do need the RTE.

In practice this has cost zero anyway, since set_plain_rel_pathlist
will surely get inlined into its sole caller.

regards, tom lane