Remove unused param rte in set_plain_rel_pathlist

Started by Zhang Minglialmost 4 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46921
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 05:32 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t46921_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t46921_1 && git checkout t46921_1

Patchset v1 (message #1) is on t46921_1

Jump to latest
#1Zhang Mingli
zmlpostgres@gmail.com

Hi, hackers

Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all.

I look at the commit e2fa76d80b(10 years ago), it’s useless since then.

Add a path to remove it.

Regards,
Zhang Mingli

Attachments:

t46921_1
v1-0001-Remove-unused-param-rte-in-set_plain_rel_pathlist.patchapplication/octet-streamDownload+4-5
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zhang Mingli (#1)
Re: Remove unused param rte in set_plain_rel_pathlist

Zhang Mingli <zmlpostgres@gmail.com> writes:

Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all.
Add a path to remove it.

I'm disinclined to change that, as it'd make set_plain_rel_pathlist
different from its sibling functions, which do need the RTE.

In practice this has cost zero anyway, since set_plain_rel_pathlist
will surely get inlined into its sole caller.

regards, tom lane