Fix the README file for MERGE command
Hi Hackers,
This is Myo Wai Thant.
I found out that there is a mistake written in executor/README file.
The actions of MERGE command can be specified as follows: INSERT, UPDATE, DELETE and DO NOTHING.
However, in the README file, the ‘UPDATE’ word is described 2 times instead of ‘DELETE’.
Therefore, I attached the patch file which fix this word usage.
It would be great if you could take a look at it.
Thank you.
Best Regards,
Myo Wai Thant
Attachments:
fix.patchapplication/octet-stream; name=fix.patchDownload
diff --git a/src/backend/executor/README b/src/backend/executor/README
index 0b5183fc4a..17775a49e2 100644
--- a/src/backend/executor/README
+++ b/src/backend/executor/README
@@ -229,7 +229,7 @@ MERGE
MERGE is a multiple-table, multiple-action command: It specifies a target
table and a source relation, and can contain multiple WHEN MATCHED and
WHEN NOT MATCHED clauses, each of which specifies one UPDATE, INSERT,
-UPDATE, or DO NOTHING actions. The target table is modified by MERGE,
+DELETE, or DO NOTHING actions. The target table is modified by MERGE,
and the source relation supplies additional data for the actions. Each action
optionally specifies a qualifying expression that is evaluated for each tuple.
On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <
myo.waithant@fujitsu.com> wrote:
The actions of MERGE command can be specified as follows: INSERT, UPDATE,
DELETE and DO NOTHING.However, in the README file, the ‘UPDATE’ word is described 2 times
instead of ‘DELETE’.Therefore, I attached the patch file which fix this word usage.
It would be great if you could take a look at it.
Apparently this is a typo. Good catch! +1.
Thanks
Richard
Hi Richard,
Thank you for your time.
Best Regards,
Myo Wai Thant
From: Richard Guo <guofenglinux@gmail.com>
Sent: Thursday, November 17, 2022 10:31 AM
To: Myo, Waithant/Ｍｙｏ Ｗ． <myo.waithant@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix the README file for MERGE command
On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <myo.waithant@fujitsu.com<mailto:myo.waithant@fujitsu.com>> wrote:
The actions of MERGE command can be specified as follows: INSERT, UPDATE, DELETE and DO NOTHING.
However, in the README file, the ‘UPDATE’ word is described 2 times instead of ‘DELETE’.
Therefore, I attached the patch file which fix this word usage.
It would be great if you could take a look at it.
Apparently this is a typo. Good catch! +1.
Thanks
Richard
On 17 Nov 2022, at 02:31, Richard Guo <guofenglinux@gmail.com> wrote:
On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <myo.waithant@fujitsu.com <mailto:myo.waithant@fujitsu.com>> wrote:
Therefore, I attached the patch file which fix this word usage.It would be great if you could take a look at it.
Apparently this is a typo. Good catch! +1.
Agreed. I've applied this down to v15 where MERGE was introduced. Thanks!
--
Daniel Gustafsson https://vmware.com/