Fix the README file for MERGE command

Started by Waithant Myo (Fujitsu)over 3 years ago4 messageshackers
Jump to latest
#1Waithant Myo (Fujitsu)
myo.waithant@fujitsu.com

Hi Hackers,

This is Myo Wai Thant.
I found out that there is a mistake written in executor/README file.

The actions of MERGE command can be specified as follows: INSERT, UPDATE, DELETE and DO NOTHING.
However, in the README file, the ‘UPDATE’ word is described 2 times instead of ‘DELETE’.

Therefore, I attached the patch file which fix this word usage.
It would be great if you could take a look at it.

Thank you.
Best Regards,
Myo Wai Thant

Attachments:

fix.patchapplication/octet-stream; name=fix.patchDownload+1-1
#2Richard Guo
guofenglinux@gmail.com
In reply to: Waithant Myo (Fujitsu) (#1)
Re: Fix the README file for MERGE command

On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <
myo.waithant@fujitsu.com> wrote:

The actions of MERGE command can be specified as follows: INSERT, UPDATE,
DELETE and DO NOTHING.

However, in the README file, the ‘UPDATE’ word is described 2 times
instead of ‘DELETE’.

Therefore, I attached the patch file which fix this word usage.

It would be great if you could take a look at it.

Apparently this is a typo. Good catch! +1.

Thanks
Richard

#3Waithant Myo (Fujitsu)
myo.waithant@fujitsu.com
In reply to: Richard Guo (#2)
RE: Fix the README file for MERGE command

Hi Richard,

Thank you for your time.

Best Regards,
Myo Wai Thant
From: Richard Guo <guofenglinux@gmail.com>
Sent: Thursday, November 17, 2022 10:31 AM
To: Myo, Waithant/Myo W. <myo.waithant@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix the README file for MERGE command

On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <myo.waithant@fujitsu.com<mailto:myo.waithant@fujitsu.com>> wrote:
The actions of MERGE command can be specified as follows: INSERT, UPDATE, DELETE and DO NOTHING.
However, in the README file, the ‘UPDATE’ word is described 2 times instead of ‘DELETE’.

Therefore, I attached the patch file which fix this word usage.
It would be great if you could take a look at it.

Apparently this is a typo. Good catch! +1.

Thanks
Richard

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Richard Guo (#2)
Re: Fix the README file for MERGE command

On 17 Nov 2022, at 02:31, Richard Guo <guofenglinux@gmail.com> wrote:
On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujitsu) <myo.waithant@fujitsu.com <mailto:myo.waithant@fujitsu.com>> wrote:
Therefore, I attached the patch file which fix this word usage.

It would be great if you could take a look at it.

Apparently this is a typo. Good catch! +1.

Agreed. I've applied this down to v15 where MERGE was introduced. Thanks!

--
Daniel Gustafsson https://vmware.com/