Typo for xl_running_xacts

Started by Japin Liover 3 years ago3 messageshackers
Jump to latest
#1Japin Li
japinli@hotmail.com

Hi, hackers

I find some typo about xl_running_xacts in comments.
Attached a patch to fix those.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Attachments:

fix-typo-for-xl_running_xacts.difftext/x-diffDownload+3-3
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Japin Li (#1)
Re: Typo for xl_running_xacts

On 17 Nov 2022, at 08:06, Japin Li <japinli@hotmail.com> wrote:

I find some typo about xl_running_xacts in comments.
Attached a patch to fix those.

Thanks, applied!

-	 * might look that we could use xl_running_xact's ->xids information to
+	 * might look that we could use xl_running_xacts->xids information to

I'm not a native english speaker, but since xl_running_xacts refers to a name
in this case and not an indication of plural possession, ending with a 's is
correct even if it ends with an 's', so I instead changed this to
"xl_running_xacts's".

--
Daniel Gustafsson https://vmware.com/

#3Japin Li
japinli@hotmail.com
In reply to: Daniel Gustafsson (#2)
Re: Typo for xl_running_xacts

On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson <daniel@yesql.se> wrote:

On 17 Nov 2022, at 08:06, Japin Li <japinli@hotmail.com> wrote:

I find some typo about xl_running_xacts in comments.
Attached a patch to fix those.

Thanks, applied!

-	 * might look that we could use xl_running_xact's ->xids information to
+	 * might look that we could use xl_running_xacts->xids information to

I'm not a native english speaker, but since xl_running_xacts refers to a name
in this case and not an indication of plural possession, ending with a 's is
correct even if it ends with an 's', so I instead changed this to
"xl_running_xacts's".

Thanks, I found other places use "xl_running_xacs'",
such as "xl_running_xacts' oldestRunningXid" in snapbuild.c.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.