Nov 2022

1 commit
pgstat: replace double lookup with IsSharedRelation()
20 Nov 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #62 of 2 reviewers saw the final version

The commit diff exactly matches #6: both add catalog/catalog.h and replace the fallback lookups with a direct return through IsSharedRelation() in src/backend/utils/activity/pgstat_relation.c. Andres Freund confirms pushing the patch in #7.

  • Bharath Rupireddysaw the final versiontrailerBharath approved the initial approach and suggested removing the temporary variable in #2, then accepted the expanded version with reservations in #4; the committed patch returns to his reviewed initial approach with that light simplification.
  • Andres Freundsaw the final versiontrailerAndres rejected distributing IsSharedRelation() and questioned inlining in #5, then committed the restored centralized implementation and confirmed the push in #7.

Credits across 1 commit

Author
Bertrand Drouvot1
Reviewer
Andres Freund1
Bharath Rupireddy1
Committer
Andres Freund1